Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Linux/ia32 is no longer officially supported for Electron >= 4 #957

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

malept
Copy link
Member

@malept malept commented Mar 5, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

See:

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #957 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #957   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         671    671           
=====================================
  Hits          671    671
Impacted Files Coverage Δ
targets.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd237af...0b28ef6. Read the comment docs.

@malept malept merged commit d94e65a into master Mar 5, 2019
@malept malept deleted the linux-ia32 branch March 5, 2019 05:10
@malept malept changed the title fix(targets): Linux/ia32 is no longer supported for Electron >= 4 fix(targets): Linux/ia32 is no longer officially supported for Electron >= 4 Mar 5, 2019
@Nikeron
Copy link

Nikeron commented Mar 13, 2019

Linux only? Win32 will be alive? Are you seriously? 👏

@malept
Copy link
Member Author

malept commented Mar 14, 2019

All platform/arch decisions are up to the Electron group in charge of releases, Electron Packager only follows their direction.

In this case, I'm probably going to revert this PR and release a new version. My understanding is that a warning will be emitted from electron-download when 32-bit Linux builds >= 4.0.0 are downloaded, so it's at the developer's risk to use them. (They may or may not work.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants