Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform: Mac App Store support #223

Merged
merged 6 commits into from Feb 18, 2016
Merged

Platform: Mac App Store support #223

merged 6 commits into from Feb 18, 2016

Commits on Feb 16, 2016

  1. Mac App Store platform support 

    - Added isPlatformMac to check whether platform build for OS X
- Changed from `codesign` to `electron-osx-sign` for code-signing
- Changed `test/mac` to be a shared script for testing both `darwin`
and `mas` platforms
- Updates on usage/readme
    @sethlu
    sethlu committed Feb 16, 2016
    Configuration menu
    Copy the full SHA
    0f3aa55 View commit details
    Browse the repository at this point in the history

  2. Indent test/mac 

    Indented for clarity in commits
    @sethlu
    sethlu committed Feb 16, 2016
    Configuration menu
    Copy the full SHA
    cf1810e View commit details
    Browse the repository at this point in the history

  3. Filter CFBundleIdentifier + set CFBundle properties 

    Fix: ix electron/packager#261
Fix: electron/packager#163
Added filterCFBundleIdentifier function
Properties to set in app plist
- CFBundleDisplayName
- CFBundleIdentifier
- CFBundleName
Properties to set in helper plist
- CFBundleDisplayName
- CFBundleIdentifier
- CFBundleName
- CFBundleExecutable
In testing script:
- Added testing with special characters
    @sethlu
    sethlu committed Feb 16, 2016
    Configuration menu
    Copy the full SHA
    92a63a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2016

  1. Opts app-copyright (NSHumanReadableCopyright on OS X) 

    Fix: maxogden#163
    @sethlu
    sethlu committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    50eb49a View commit details
    Browse the repository at this point in the history

  2. Use Electron v0.35.6 for testing 

    The latest version of Electron to best support `mas` build
    @sethlu
    sethlu committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    ad1e9f7 View commit details
    Browse the repository at this point in the history

  3. Add basic Mac App Store docs + differentiate between host & target pl… 

    …atforms
    @malept @sethlu
    malept authored and sethlu committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    9212919 View commit details
    Browse the repository at this point in the history