Add protocol/protocol-name docs and test #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
protocol-docs-and-tests
branch
from
b5740a2
to
ac7ae78
Compare
| cause URLs such as `myapp://path` to be opened with the app. This option can be | ||
| specified multiple times to register multiple protocol schemes with the app. | ||
| Maps to the `CFBundleURLSchemes` metadata property. This argument requires | ||
| a corresponding `--protocol-name` argument. |
There was a problem hiding this comment.
This is currently written more CLI-centric than API-centric (although it's a little too verbose for usage.txt). s/argument/option/g and remove the flag prefix from protocol-name.
|
Needs some docs in |
kevinsawicki
force-pushed
the
protocol-docs-and-tests
branch
from
9c08560
to
d63200a
Compare
kevinsawicki
force-pushed
the
protocol-docs-and-tests
branch
from
d63200a
to
b3d24f8
Compare
|
@malept I've updated |
|
|
||
| *Array* of *String*s | ||
|
|
||
| The URL protocol scheme to associate the app with. Specifying `myapp` would |
There was a problem hiding this comment.
The URL protocol scheme
scheme(s)
| specified multiple times to register multiple protocol schemes with the app. | ||
| Maps to the `CFBundleURLSchemes` metadata property. This option requires | ||
| a corresponding `protocol-name` option to be specified. | ||
| The URL protocol scheme(s) to associate the app with. Specifying `myapp` would |
There was a problem hiding this comment.
Last thing, I swear:
For example, specifying
myapp[...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation and an initial test for the
protocol/protocol-nameoption.Closes #121