Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to pick one asar, instead of keeping both #2

Closed
NielsLeenheer opened this issue Nov 18, 2020 · 4 comments
Closed

Add option to pick one asar, instead of keeping both #2

NielsLeenheer opened this issue Nov 18, 2020 · 4 comments

Comments

@NielsLeenheer
Copy link
Contributor

It would be nice to have an option which you can use to configure what to do with the two asar files. Currently the default behaviour is to keep them both and use a runtime check to determine which to run.

The asar of our app quite big, about 30 MB and the arm64 and x64 versions are identical. In our case the default behaviour would add an unneeded 30 MB to our .app.

Perhaps four options:
x64, arm64, both and auto.

With auto doing a check to see if the two asar's are identical. If identical, pick one. And if different, keep both.
@NielsLeenheer
Copy link
Contributor Author

Actually...

Adding an option is not really necessary. Just make the 'auto' option the default behaviour and it will automatically work in both cases.

@MarshallOfSound
Copy link
Member

@NielsLeenheer are the SHAs of your asar files the same? If so then yeah, adding that kind of optimization makes sense to me

@NielsLeenheer
Copy link
Contributor Author

Yes, the SHAs are identical.

@NielsLeenheer NielsLeenheer mentioned this issue Nov 19, 2020
Merged
MarshallOfSound pushed a commit that referenced this issue Nov 19, 2020
@NielsLeenheer
fix: no asar support (#4), renamed directories (#5) and check if we n…
82acb6f 
…eed to duplicate asar's (#2) (#8)

* fix: no asar support (#4), renamed directories (#5) and check if we need to duplicate asar's (#1)

* Add missing newline
@MarshallOfSound
Copy link
Member

Fixed in 82acb6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NielsLeenheer @MarshallOfSound