Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the app does not use asar's, the universal binary fails to start #4

Closed
NielsLeenheer opened this issue Nov 18, 2020 · 1 comment
Closed

When the app does not use asar's, the universal binary fails to start #4

NielsLeenheer opened this issue Nov 18, 2020 · 1 comment

Comments

@NielsLeenheer
Copy link
Contributor

The app directories from the x64 and arm64 builds are renamed to x64.app and arm64.app. But the index.js from the entry-asar expects asar's and tries to load from x64.app.asar and arm64.app.asar.
@NielsLeenheer NielsLeenheer mentioned this issue Nov 19, 2020
Merged
MarshallOfSound pushed a commit that referenced this issue Nov 19, 2020
@NielsLeenheer
fix: no asar support (#4), renamed directories (#5) and check if we n…
82acb6f 
…eed to duplicate asar's (#2) (#8)

* fix: no asar support (#4), renamed directories (#5) and check if we need to duplicate asar's (#1)

* Add missing newline
@MarshallOfSound
Copy link
Member

Fixed in 82acb6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NielsLeenheer @MarshallOfSound