Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using of qualified eastl compare function names #333

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

miherius
Copy link
Contributor

@miherius miherius commented Dec 9, 2019

Fixing of compilation error when some of eastl containers used with std types. Reason: ambiguity of equal() and lexicographical_compare() functions call in overloaded compare operators, which conflicts with its std counterparts. So, you can't compare eastl::vector<std::string> using operators==(), but compare of eastl::array<std::string> works fine, because latter use qualified names for its compare operators.

This PR just unifies using of compare functions across all eastl containers. So, all unqualified calls to equal() and lexicographical_compare() functions replaced with quailified ones.

I'm not sure that's a good idea to write tests which can't be compiled in the pre-PR version, so I skipped this part.

Tested on VS 2017 and GCC 7.4

@rparolin
Copy link
Contributor

Thanks for the PR!

@rparolin rparolin merged commit 4b6dda1 into electronicarts:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants