Using of qualified eastl compare function names #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing of compilation error when some of
eastl
containers used withstd
types. Reason: ambiguity ofequal()
andlexicographical_compare()
functions call in overloaded compare operators, which conflicts with itsstd
counterparts. So, you can't compareeastl::vector<std::string>
usingoperators==()
, but compare ofeastl::array<std::string>
works fine, because latter use qualified names for its compare operators.This PR just unifies using of compare functions across all
eastl
containers. So, all unqualified calls toequal()
andlexicographical_compare()
functions replaced with quailified ones.I'm not sure that's a good idea to write tests which can't be compiled in the pre-PR version, so I skipped this part.
Tested on VS 2017 and GCC 7.4