Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: TheThingsStack v3 support #19

Closed
aparcar opened this issue Jan 28, 2021 · 5 comments
Closed

decoder: TheThingsStack v3 support #19

aparcar opened this issue Jan 28, 2021 · 5 comments
Assignees

Comments

@aparcar
Copy link
Contributor

aparcar commented Jan 28, 2021

The new stack uses a slightly different format, could you please update/add another decoder.js script to support v3?

https://www.thethingsindustries.com/docs/integrations/payload-formatters/javascript/

@sabas1080 sabas1080 self-assigned this Jan 29, 2021
@sabas1080
Copy link
Member

Hi @aparcar

Welcome contribution :D

@amotl
Copy link

amotl commented Mar 6, 2021

Hi Paul and Sabas,

while I am not that much into the very details, I would like to point out that @thiasB just added hiveeyes/terkin-datalogger@71699ded to the Terkin Datalogger.

In that manner, it might help to compare the implementations of [1] vs. [2], where [1] was already derived from this repository. By mentioning it, we want to take the chance to send a big thank you to @xoseperez, @ricaun and David, who we discovered to have originally committed to decoder.js.

Keep up the spirit and with kind regards,
Andreas.

[1] https://github.com/hiveeyes/terkin-datalogger/blob/master/client/TTN/decoder_v2.js
[2] https://github.com/hiveeyes/terkin-datalogger/blob/master/client/TTN/decoder_v3.js

@amotl
Copy link

amotl commented Mar 6, 2021

Maybe you can also submit a pull request here, @thiasB?

@thiasB
Copy link
Contributor

thiasB commented Mar 6, 2021

see #23

@sabas1080
Copy link
Member

Thanks @amotl and @thiasB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants