Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aspect ratio free cropping of uploaded images #2356

Closed
benparsons opened this issue Nov 6, 2020 · 6 comments · Fixed by #8325
Closed

Allow aspect ratio free cropping of uploaded images #2356

benparsons opened this issue Nov 6, 2020 · 6 comments · Fixed by #8325
Labels
A-Media T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@benparsons
Copy link
Member

Is your feature request related to a problem? Please describe.
You want to share only part of an image, would like to crop it immediately before uploading.

Describe the solution you'd like
Tiny editor similar to WhatsApp

Describe alternatives you've considered
None, idea stolen from WhatsApp.

@benparsons benparsons added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Media labels Nov 6, 2020
@T-bond
Copy link

T-bond commented Nov 6, 2020

There is already cropping functionality. Just the buttons invisible/black on black. In the current release they are fixed.
Screenshot_20201106-205532_Element (Riotim)

@SeerLite
Copy link

Isn't that only aspect ratio cropping though? I couldn't figure out how to crop freely like on other apps.
I think aspect ratio cropping is really unintuitive, it has been a common complaint from my friends

@SeerLite
Copy link

I'd also like to suggest adding some basic editing functionality like the ability to add text or draw on top of images. They're not as important as cropping but still missed a lot from other IMs, in case you wanna consider them.

@thefeiter
Copy link

Isn't that only aspect ratio cropping though? I couldn't figure out how to crop freely like on other apps. I think aspect ratio cropping is really unintuitive, it has been a common complaint from my friends

Every time I want to send only part of a screenshot, I have to use my phones built in image editor to be able to crop with a free aspect ratio. I would really love to see free cropping as well.
I think those are things making it hard for people to transfer to matrix since all other messenger apps have this as a basic feature.

@thefeiter
Copy link

Maybe the issue can be renamed to "Allow aspect ratio free cropping of images"

@benparsons benparsons changed the title Include a simple image-crop tool when uploading images Allow aspect ratio free cropping of uploaded images Apr 13, 2022
@mxvin
Copy link

mxvin commented Jul 28, 2022

This feature is available from upstream libs. See Yalantis/uCrop#801 (comment)
Just add some line on GalleryOrCameraDialogHelper.kt and that's it.
This is a very basic feature, important and must be available ASAP 😄

UCrop.Options options = new UCrop.Options();
options.setFreeStyleCropEnabled(true);

networkException added a commit to networkException/element-android that referenced this issue Apr 11, 2023
This feature was disabled in 3ac2296.

Resolves element-hq#2356

Signed-off-by: networkException <git@nwex.de>
networkException added a commit to networkException/element-android that referenced this issue Apr 11, 2023
This feature was disabled in 3ac2296.

Resolves element-hq#2356

Signed-off-by: networkException <git@nwex.de>
networkException added a commit to networkException/element-android that referenced this issue Apr 11, 2023
This feature was disabled in 3ac2296.

Resolves element-hq#2356

Signed-off-by: networkException <git@nwex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Media T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants