Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated timeline, many read receipts #5166

Closed
timokoesters opened this issue Feb 5, 2022 · 12 comments · Fixed by #6318
Closed

Repeated timeline, many read receipts #5166

timokoesters opened this issue Feb 5, 2022 · 12 comments · Fixed by #6318
Assignees
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@timokoesters
Copy link
Contributor

timokoesters commented Feb 5, 2022

Steps to reproduce

Log in to a conduit account.
Accept a federated invite into a new room.

The problem seems to be related to the limited flag for syncs or the /messages endpoint.

Outcome

Your phone model

Operating system version

Application version and app store

Homeserver

conduit.rs

Will you send logs?

No

@timokoesters timokoesters added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 5, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Feb 5, 2022
@BillCarsonFr
Copy link
Member

So back pagination is like reloading the same page again
It's only when accepting a federated invite into a new room?

@timokoesters
Copy link
Contributor Author

It's easy to reproduce when you are at the "start" of a timeline (/messages doesn't return any new events), but it seems to happen in other cases too.

@BillCarsonFr
Copy link
Member

There is a difference between an empty pagination result on conduit.rs and synapse.

Synapse

{"chunk":[],"start":"t1-1339_71365_114_338_608_1_436_640_1","end":"t1-1339_71365_114_338_608_1_436_640_1"}

Conduit

{"start":"19057171","chunk":[]}

Looks like somehow android is expected the end to be set, wich as per spec shouldn't

end

If no further events are available (either because we have reached the start of the timeline, or because the user does not have permission to see any more events), this property is omitted from the response.

@BillCarsonFr
Copy link
Member

Quikly confirmed by updating android code to use start for end when chunk is empty and it's working fine

@BillCarsonFr BillCarsonFr self-assigned this Feb 5, 2022
@ouchadam ouchadam added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 8, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Feb 8, 2022
@HarHarLinks
Copy link
Contributor

I've hit something very similar on SchildiChat based on 1.4.4 with synapse 1.54.0.
I opened a room, clicked to jump to first unread, tried to scroll down from there but the timeline would repeat itself endlessly from there.

Expand to show a screenshot of the loop

image

I did rageshake this (to the schildi devs).

@MadLittleMods
Copy link

MadLittleMods commented Mar 24, 2022

I reproduced a repeating never-ending timeline a lot when I had to use Element Android on a trip (matrix.org which is Synapse). Here is a rageshake, https://github.com/matrix-org/element-android-rageshakes/issues/35689. This was with normal messages, not just state events and read receipts.

@MrAureliusR
Copy link

This bit me when self-hosting a Conduit server. It's just an endless scroll of the same messages over and over, and duplicated read receipts.
element_issue
.

@SpiritCroc
Copy link
Contributor

SpiritCroc commented May 3, 2022

I wonder if this issue will be fixed with 638e18e from #5878 .

That PR and some more experimental changes for timeline loops are already included in the latest SchildiChat beta (1.4.13.sc53-test1), if anybody is interested in testing it.

@MrAureliusR
Copy link

I wonder if this issue will be fixed with 638e18e from #5878 .

That PR and some more experimental changes for timeline loops are already included in the latest SchildiChat beta (1.4.13.sc53-test1), if anybody is interested in testing it.

Just downloaded SchildiChat on my Android device and joined the beta. After it updated to the beta version, signed into my homeserver -- exact same issue as with Element.

@SpiritCroc
Copy link
Contributor

I wonder if this issue will be fixed with 638e18e from #5878 .
That PR and some more experimental changes for timeline loops are already included in the latest SchildiChat beta (1.4.13.sc53-test1), if anybody is interested in testing it.

Just downloaded SchildiChat on my Android device and joined the beta. After it updated to the beta version, signed into my homeserver -- exact same issue as with Element.

Sure you have the right version? (Note we distribute betas on our own fdroid server, google play betas are usually outdated)

@manuroe manuroe added this to Current Sprint in Android App Team Jun 2, 2022
@manuroe manuroe moved this from Current Sprint to In progress in Android App Team Jun 14, 2022
@ganfra ganfra changed the title Repeated timeline, many read receipts on Conduit Repeated timeline, many read receipts Jun 15, 2022
@ganfra
Copy link
Contributor

ganfra commented Jun 15, 2022

This also happens on synapse if you have a version > 1.6 (matrix-org/synapse#12903)
Related: #6312

Issue triage automation moved this from Triaged to Closed Jun 21, 2022
Android App Team automation moved this from In progress to Merged Jun 21, 2022
@babolivier
Copy link

This also happens on synapse if you have a version > 1.6

For the paper trail and future digital archaeologists, the Synapse versions triggering this bug are > 1.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
9 participants