Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joining a DM shows infinite room join events in the timeline until app crashes #6312

Closed
kittykat opened this issue Jun 15, 2022 · 6 comments · Fixed by #6318
Closed

Joining a DM shows infinite room join events in the timeline until app crashes #6312

kittykat opened this issue Jun 15, 2022 · 6 comments · Fixed by #6318
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

I don't know how to trigger this bug, but it was reproducible until I opened the app

  1. Other person sends some messages in the DM
  2. Receive an invite to a DM and click the notification
  3. See the invite dialog open in the app (it doesn't say who the invite is from, the title of the dialog is !room1d:homeserver.org
  4. Click "Join"
  5. App crashes

I could reproduce the behaviour until I opened the DM in the web app, then it started working correctly. I tried submitting a rageshake after the app restarted and it claimed to have submitted correctly but I can't see it in the rageshake repo.

Outcome

What did you expect?

See DM

What happened instead?

Room opens, see a "membership change" event in the timeline, see number of the membership change events counting up. App crashes.

invite.mp4

Your phone model

Pixel 2

Operating system version

Android 11

Application version and app store

Element version 1.4.20; Matrix SDK 1.4.20, olm version 3.2.11

Homeserver

matrix.org, the other person is on element.io

Will you send logs?

Yes

Are you willing to provide a PR?

No
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Critical Prevents work, causes data loss and/or has no workaround labels Jun 15, 2022
@weeman1337
Copy link
Contributor

weeman1337 commented Jun 15, 2022 •
edited
Loading

Same on version 1.4.14

  • Joining user on self-hosted homeserver running synapse v1.60.0
  • Inviting user on Matrix.org

The update to 1.60 happened yesterday. Didn't experience this issue before.

@weeman1337
Copy link
Contributor

Also happening if both are non-Matrix.org (Synapse 1.60)

This was referenced Jun 15, 2022
Closed
Merged
@kittykat
Copy link
Contributor Author

@bmarty apparently this is happening quite often in the community

@kittykat kittykat added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Jun 17, 2022
@akoyaxd akoyaxd mentioned this issue Jun 19, 2022
Open
@akoyaxd
Copy link

akoyaxd commented Jun 19, 2022

#6342

@akoyaxd
Copy link

akoyaxd commented Jun 19, 2022

I could reproduce this Issue on Element 1.4.16, 1.4.18 and 1.4.20; all gplay.

@richvdh
Copy link
Member

richvdh commented Jun 27, 2022

I believe this was introduced by matrix-org/synapse#12903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fga/simplify timeline logic element-hq/element-android
4 participants
@kittykat @richvdh @weeman1337 @akoyaxd