Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing camera on video mute is unreliable #847

Closed
dbkr opened this issue Jan 12, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3078
Closed

Releasing camera on video mute is unreliable #847

dbkr opened this issue Jan 12, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3078
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems X-Cannot-Reproduce Needs reproduction steps

Comments

@dbkr
Copy link
Member

dbkr commented Jan 12, 2023 •
edited
Loading

Steps to reproduce

  1. Enter call
  2. Mute video

Outcome

What did you expect?

Camera light goes off

What happened instead?

Camera light stays on sometimes, although it does work other times. Haven't yet found a correlation - I'd assume we must have a stray stream kicking around. It still fails sometimes when I'm the the only person in the call.

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No
@dbkr dbkr added T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 12, 2023
@SimonBrandner SimonBrandner added the X-Cannot-Reproduce Needs reproduction steps label Jan 13, 2023
@SimonBrandner
Copy link
Contributor

I can't repro :/

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Jan 19, 2023
@dbkr
Handle group call getting initialised twice in quick succession
495642d 
This happens in dev mode with React 18 and caused extra user media
stream to end up floating around.

Fixes element-hq/element-call#847
@dbkr dbkr mentioned this issue Jan 19, 2023
Merged
3 tasks
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 1, 2023
@su-ex
Merge tag 'v23.2.0' into sc
7158a99 
* Implement decryption via the rust sdk ([\matrix-org#3074](matrix-org#3074)).
* Handle edits which are bundled with an event, per MSC3925 ([\matrix-org#3045](matrix-org#3045)).
* Add null check for our own member event ([\matrix-org#3082](matrix-org#3082)).
* Handle group call getting initialised twice in quick succession ([\matrix-org#3078](matrix-org#3078)). Fixes element-hq/element-call#847.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952. Contributed by @justjanne.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Fix spurious "Decryption key withheld" messages ([\matrix-org#3061](matrix-org#3061)). Fixes element-hq/element-web#23803.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems X-Cannot-Reproduce Needs reproduction steps
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle group call getting initialised twice in quick succession matrix-org/matrix-js-sdk
2 participants
@dbkr @SimonBrandner