Fix spurious "Decryption key withheld" messages #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to update the error message
When we receive an `m.unavailable` notification, do not show it as "Decryption key withheld".
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Feb 1, 2023
* Implement decryption via the rust sdk ([\matrix-org#3074](matrix-org#3074)). * Handle edits which are bundled with an event, per MSC3925 ([\matrix-org#3045](matrix-org#3045)). * Add null check for our own member event ([\matrix-org#3082](matrix-org#3082)). * Handle group call getting initialised twice in quick succession ([\matrix-org#3078](matrix-org#3078)). Fixes element-hq/element-call#847. * Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952. Contributed by @justjanne. * Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216. * Fix spurious "Decryption key withheld" messages ([\matrix-org#3061](matrix-org#3061)). Fixes element-hq/element-web#23803. * Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#23803
Do not store
m.room_key.withheldevents with a code ofm.unavailablein the crypto store: doing so causes a spurious "key withheld" message, and may overwrite more useful messages.This also includes a change to ensure we update the error message when we receive an
m.room_key.withheld- mostly driven by the need to test the change, but seems like an improvement anyway.Here's what your changelog entry will look like:
馃悰 Bug Fixes