Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad linkification of matrix alias and URL #4258

Closed
manuroe opened this issue Apr 23, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1079 or matrix-org/matrix-ios-sdk#1081
Closed

Bad linkification of matrix alias and URL #4258

manuroe opened this issue Apr 23, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1079 or matrix-org/matrix-ios-sdk#1081
Labels
A-Message P3 X-Regression
Milestone
Sprint - Element ...

Comments

@manuroe
Copy link
Member

manuroe commented Apr 23, 2021 •
edited
Loading

This problem is not new but the resurrection of the CI for MatrixKit showed that we have tests that failed on it.

The bugs on the UI look like:
ima_4a6869c
@manuroe manuroe added this to the Sprint - Element 1.3.6 milestone Apr 23, 2021
@manuroe manuroe mentioned this issue Apr 26, 2021
Merged
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Apr 26, 2021
@manuroe
MXTools: Fix bad linkification of matrix alias and URL
eebc96a 
Fix element-hq/element-ios#4258
@manuroe manuroe mentioned this issue Apr 26, 2021
Merged
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Apr 28, 2021
@manuroe
MXTools: Fix bad linkification of matrix alias and URL for real
6ff04d7 
Fix element-hq/element-ios#4258

This time there is no compromise. Disabled tests pass now. There are more tests, include one for the original GH issue where `@bob:matrix.org.` must not be considered as a valid matrix id.

Visualisation of the new `MATRIX_HOMESERVER_DOMAIN_REGEX `: https://regexper.com/#%5BA-Z0-9%5D%2B%28%28%5C.%7C%5C-%29%5BA-Z0-9%5D%2B%29%7B0%2C%7D%28%3A%5B0-9%5D%7B2%2C5%7D%29%3F
@manuroe manuroe mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Message P3 X-Regression
Projects
None yet
Milestone
Sprint - Element 1.3.6
1 participant
@manuroe