Log decryption error details as context in AnalyticsEvent #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
BillCarsonFr,
a team and
stefanceriu
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qCgWGy |
Anderas
requested review from
a team and
ismailgulek
and removed request for
stefanceriu and
a team
ismailgulek
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6046
Use the existing
contextproperty ofAnalyticsEventtype to log additional details about UISI and decryption errors, which are currently being discared (and making it harder to monitor and fix errors). Thecontextis just a string field and does not have any standardized format, in this particular PR I am logging the data as "code: X, description: more details of the error".This PR is meant as a transitionary solution to find out faster what the majority of "unknown" errors in our analytics are. As the next step we would like to define a dedicated
DecryptionErrortype in the analytics schema and define a broader range of errors suitable for our analytics.