Skip to content

Commit

Permalink
Consolidate i18n check into a reusable workflow (#22248)
Browse files Browse the repository at this point in the history
* Fix i18n check bypass for RiotTranslateBot

* Consolidate i18n check into a reusable workflow
  • Loading branch information
t3chguy committed May 20, 2022
1 parent b2d057b commit fab5279
Showing 1 changed file with 1 addition and 33 deletions.
34 changes: 1 addition & 33 deletions .github/workflows/static_analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,39 +28,7 @@ jobs:

i18n_lint:
name: "i18n Check"
runs-on: ubuntu-latest
permissions:
pull-requests: read
steps:
- uses: actions/checkout@v2

- name: "Get modified files"
id: changed_files
if: github.event_name == 'pull_request'
uses: tj-actions/changed-files@v19
with:
files: |
src/i18n/strings/*
files_ignore: |
src/i18n/strings/en_EN.json
- name: "Assert only en_EN was modified"
if: |
github.event_name == 'pull_request' &&
github.actor != 'RiotTranslateBot' &&
steps.changed_files.outputs.any_modified == 'true'
run: |
echo "You can only modify en_EN.json, do not touch any of the other i18n files as Weblate will be confused"
exit 1
- uses: actions/setup-node@v3
with:
cache: 'yarn'

# Does not need branch matching as only analyses this layer
- name: Install Deps
run: "yarn install --pure-lockfile"

- name: i18n Check
run: "yarn run diff-i18n"
uses: matrix-org/matrix-react-sdk/.github/workflows/i18n_check.yml@develop

js_lint:
name: "ESLint"
Expand Down

0 comments on commit fab5279

Please sign in to comment.