Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Integration Manager preferences in account data and allow user to change them somewhere sensible #10161

Closed
lampholder opened this issue Jun 25, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3308
Closed

Store Integration Manager preferences in account data and allow user to change them somewhere sensible #10161

lampholder opened this issue Jun 25, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3308
Assignees
@turt2live
Labels
A-Integrations A-User-Settings P1 Privacy

Comments

@lampholder
Copy link
Member

The User Settings UX for #4913, basically.
@lampholder
Copy link
Member Author

I don't think there's any benefit to my mocking up a UX for this - there are quite a few places one could put this UX :\

It could be implemented in User Settings (along the lines of #10094) or it could be in the IM UX somewhere).

What we need (as a minimum) is for a user to be able to:

  • choose not to use an IM at all
    • and Riot should handle this gracefully
    • they should be made aware that this isn't going to do anything to existing widgets
  • choose a different IM
    • we should verify that it is an IM
    • we should prompt the user to ready and accept the IM's policy docs
      • (does this need to be done at config change, or at first use?)
    • existing widgets should 'just work'

@lampholder lampholder changed the title User Settings UX to change Integration Manager Store Integration Manager preferences in account data and allow user to change them somewhere sensible Jun 25, 2019
@turt2live
Copy link
Member

proposal for this: matrix-org/matrix-spec-proposals#1957 (cc from #4913)

@nadonomy
Copy link
Member

nadonomy commented Jul 5, 2019

After validating today, latest comps are in Zeplin, as a part of registration & settings: https://zpl.io/brMdWo3

@jryans jryans added phase:2 and removed phase:1 labels Jul 19, 2019
@turt2live turt2live self-assigned this Aug 7, 2019
@turt2live turt2live added this to In Progress in Web App Team via automation Aug 7, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 9, 2019
@turt2live
Refactor integration manager handling into a common place
ffa49df 
It was already in a common place, but this is the boilerplate for supporting multiple integration managers, and multiple integration manager sources. 

For element-hq/element-web#4913 / element-hq/element-web#10161
@turt2live turt2live mentioned this issue Aug 9, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 9, 2019
@turt2live
Read integration managers from account data
74ce5c3 
For element-hq/element-web#4913 / element-hq/element-web#10161

Relies on the structure defined by [MSC1957](matrix-org/matrix-spec-proposals#1957)

This is just the bit of code to parse the user's widgets (while watching for changes) and allow for it to be the default manager.
@turt2live turt2live mentioned this issue Aug 9, 2019
Merged
@turt2live
Copy link
Member

Terms acceptance is #10539

@turt2live turt2live mentioned this issue Aug 12, 2019
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 12, 2019
@turt2live
Support changing your integration manager in the UI
f75855f 
Part of element-hq/element-web#10161
@turt2live turt2live mentioned this issue Aug 12, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 12, 2019
@turt2live
Support changing your integration manager in the UI
03d735f 
Part of element-hq/element-web#10161
@turt2live turt2live moved this from In Progress to In Review in Web App Team Aug 12, 2019
@turt2live
Copy link
Member

PRs in this issue:

Future work:

Web App Team automation moved this from In Review to In Test Aug 14, 2019
@jonaharagon jonaharagon mentioned this issue Oct 10, 2019
Closed
7 tasks
@Mikaela Mikaela mentioned this issue Feb 19, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Integrations A-User-Settings P1 Privacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support changing your integration manager in the UI matrix-org/matrix-react-sdk
4 participants
@jryans @turt2live @lampholder @nadonomy