Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC1957: Integration manager discovery #1957

Merged
merged 13 commits into from
Aug 26, 2019
Merged

MSC1957: Integration manager discovery #1957

merged 13 commits into from
Aug 26, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 8, 2019 •
edited by anoadragon453
Loading

Rendered
Upstream proposal: MSC1956 - Integrations API
Discussion room: #msc-integrations-api:t2bot.io

This is being contributed under the hat of "author of Dimension":

Signed-off-by: Travis Ralston <travis@t2bot.io>

@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review labels Apr 8, 2019
@turt2live turt2live changed the title Proposal for integration manager discovery MSC1957: Integration manager discovery Apr 8, 2019
@turt2live turt2live mentioned this pull request Apr 8, 2019
Draft
@jryans @turt2live
Spelling
13d6368 
Co-Authored-By: turt2live <travpc@gmail.com>
@turt2live turt2live mentioned this pull request Apr 18, 2019
Closed
@turt2live turt2live mentioned this pull request Jun 18, 2019
Closed
@turt2live turt2live added the integrations Integration (Manager) API label Jun 20, 2019
@turt2live turt2live mentioned this pull request Jun 25, 2019
Closed
@turt2live turt2live mentioned this pull request Jun 29, 2019
Open
7 tasks
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Aug 9, 2019
@turt2live
Read integration managers from account data
74ce5c3 
For element-hq/element-web#4913 / element-hq/element-web#10161

Relies on the structure defined by [MSC1957](matrix-org/matrix-spec-proposals#1957)

This is just the bit of code to parse the user's widgets (while watching for changes) and allow for it to be the default manager.
@turt2live turt2live mentioned this pull request Aug 9, 2019
Merged
jaywink
jaywink reviewed Aug 12, 2019
View reviewed changes
Copy link
Member

@jaywink jaywink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all in all really good 👍

@turt2live
Copy link
Member Author

For the client authors:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Aug 12, 2019 •
edited by ara4n
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Aug 12, 2019
@turt2live
Copy link
Member Author

Partial implementation: matrix-org/matrix-react-sdk#3308

@turt2live turt2live mentioned this pull request Aug 15, 2019
Closed
6 tasks
richvdh
richvdh reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections from me

@mscbot reviewed

proposals/1957-integrations-discovery.md
mechanism. The added optional fields, which should not affect a client's ability to log a user in, are:
```json
{
"m.integrations": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, why a managers key within m.integrations, rather than m.integration_managers ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future expansion is really the only answer I have here. The other thing would be vague and not thought out things like possibly decentralized integrations, whatever that means.

proposals/1957-integrations-discovery.md Outdated Show resolved Hide resolved
proposals/1957-integrations-discovery.md Outdated Show resolved Hide resolved
@jryans jryans added the phase:2 label Aug 16, 2019
This was referenced Aug 22, 2019
Merged
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Aug 23, 2019
@turt2live
Support multiple integration managers behind a labs flag
b3cda4b 
Fixes element-hq/element-web#10622
Implements [MSC1957](matrix-org/matrix-spec-proposals#1957)

Design is not final.
@mscbot
Copy link
Collaborator

mscbot commented Aug 26, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Aug 26, 2019
@turt2live turt2live merged commit 0265817 into master Aug 26, 2019
@turt2live turt2live deleted the travis/msc/integrations/discovery branch August 26, 2019 01:25
@turt2live turt2live self-assigned this Aug 26, 2019
@turt2live
Copy link
Member Author

turt2live commented Aug 26, 2019 •
edited
Loading

Implementations:

@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Aug 26, 2019
@jaywink
Copy link
Member

jaywink commented Aug 30, 2019 •
edited
Loading

This is now implemented and deployed in Scalar as well.

This was referenced Oct 1, 2019
Open
Open
@turt2live turt2live mentioned this pull request Oct 1, 2019
Closed
@manuroe manuroe mentioned this pull request Nov 4, 2019
Closed
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this pull request Nov 7, 2019
@manuroe
Well-known: Expose "m.integrations" according to MSC1957
76682f7 
matrix-org/matrix-spec-proposals#1957
element-hq/element-ios#2815
aaronraimist added a commit to aaronraimist/matrix-docker-ansible-deploy that referenced this pull request Dec 5, 2019
@aaronraimist
Implement MSC1957: Integration manager discovery
fe93227 
matrix-org/matrix-spec-proposals#1957

Yay Riot iOS now supports integration manager discovery!
@Mikaela Mikaela mentioned this pull request Feb 19, 2020
Closed
4 tasks
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020
@turt2live turt2live mentioned this pull request May 6, 2020
Closed
@clokep clokep mentioned this pull request Jun 15, 2020
Closed
@dontub dontub mentioned this pull request Jul 2, 2020
Closed
@turt2live turt2live mentioned this pull request Sep 2, 2020
Draft
6 tasks
@turt2live turt2live added the blocked Something needs to be done before action can be taken on this PR/issue. label Apr 6, 2021
@0xdevalias 0xdevalias mentioned this pull request Dec 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans left review comments

@uhoreg uhoreg uhoreg left review comments

@jaywink jaywink jaywink left review comments

@anoadragon453 anoadragon453 anoadragon453 left review comments

@richvdh richvdh richvdh left review comments

Assignees

@turt2live turt2live

Labels
blocked Something needs to be done before action can be taken on this PR/issue. disposition-merge integrations Integration (Manager) API kind:feature MSC for not-core and not-maintenance stuff privacy-sprint Temporary label: privacy-related stuff proposal A matrix spec change proposal spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec
Projects
Spec Core Team Backlog
Status: BLOCKED, requires spec writing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@turt2live @mscbot @jaywink @jryans @uhoreg @anoadragon453 @richvdh