Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing messages whilst client suspended #10269

Closed
dbkr opened this issue Jul 5, 2019 · 3 comments · Fixed by matrix-org/matrix-js-sdk#979
Closed

Missing messages whilst client suspended #10269

dbkr opened this issue Jul 5, 2019 · 3 comments · Fixed by matrix-org/matrix-js-sdk#979
Assignees
@dbkr
Labels
P1 T-Defect X-Regression X-Release-Blocker

Comments

@dbkr
Copy link
Member

dbkr commented Jul 5, 2019 •
edited

Reports of messages being missing in a room in the time between closing a laptop lid in the evening and opening it in the morning.
@dbkr dbkr added the T-Defect label Jul 5, 2019
@erikjohnston
Copy link
Member

erikjohnston commented Jul 5, 2019 •
edited

The server side gap for this device for syncs:

2019-07-05 00:14:47,542 - synapse.util.caches.response_cache - 148 - INFO - GET-5714271 - [sync]: no cached result for [(...., 30000, 's1007546364_757261264_1112663_316494932_173348576_781042_27761293_15523645_50638', '136', False, 'NBHOQUBWME')], calculating new one
2019-07-05 02:15:51,775 - synapse.util.caches.response_cache - 148 - INFO - GET-5920214 - [sync]: no cached result for [(...., 0, 's1007546586_757261264_1112781_316495034_173348689_781042_27761298_15523650_50638', '136', False, 'NBHOQUBWME')], calculating new one
2019-07-05 08:36:46,383 - synapse.util.caches.response_cache - 148 - INFO - GET-6644991 - [sync]: no cached result for [(...., 0, 's1007605130_757261264_1142240_316516335_173369903_781066_27764420_15524660_50641', '136', False, 'NBHOQUBWME')], calculating new one
2019-07-05 08:36:53,704 - synapse.util.caches.response_cache - 148 - INFO - GET-6645293 - [sync]: no cached result for [(...., 0, 's1007843712_757261264_1265713_316610731_173455165_781159_27771265_15528916_50667', '136', False, 'NBHOQUBWME')], calculating new one
2019-07-05 08:36:58,132 - synapse.util.caches.response_cache - 148 - INFO - GET-6645536 - [sync]: no cached result for [(...., 30000, 's1007843855_757261264_1265768_316610779_173455202_781159_27771269_15528920_50667', '136', False, 'NBHOQUBWME')], calculating new one

@jryans
Copy link
Collaborator

jryans commented Jul 5, 2019 •
edited

This seems likely to be related:

Caught /sync error TypeError: _event.getPushActions(...) is null
    MatrixClient/<@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:3278:42
    emit@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:340785:7
    _handleEvent@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:318:42
    forSource@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:331:25
    emit@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:340780:5
    ./matrix-js-sdk/lib/models/room.js/Room.prototype.addReceipt@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:31032:10
    ./matrix-js-sdk/lib/models/room.js/Room.prototype.addLiveEvents@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:30843:18
    _callee9$@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:37562:54
    tryCatch@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:52823:40
    invoke@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:53057:22
    defineIteratorMethods/</prototype[method]@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:52875:21
From previous event:
    _callee10$/</<@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:37601:46
From previous event:
    _callee10$@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:37391:74
    tryCatch@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:52823:40
    invoke@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:53057:22
    defineIteratorMethods/</prototype[method]@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:52875:21
From previous event:
    ./matrix-js-sdk/lib/sync.js/</SyncApi.prototype._processSyncResponse</<@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:37689:22
    _callee7$@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:36995:60
From previous event:
    ./matrix-js-sdk/lib/sync.js/</SyncApi.prototype._onSyncError@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:37164:29
    _callee7$@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:36953:30
    tryCatch@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:52823:40
    invoke@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:53057:22
    defineIteratorMethods/</prototype[method]@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:52875:21
    run@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:334454:22
    notify/<@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:334471:30
    flush@https://riot.im/develop/bundles/645ebd9047c7890adee3/bundle.js:330169:9

@dbkr dbkr self-assigned this Jul 5, 2019
@dbkr dbkr added this to Raging Inferno 🔥🔥🔥 in Web App Team Jul 5, 2019
@dbkr dbkr moved this from Raging Inferno 🔥🔥🔥 to In Progress in Web App Team Jul 5, 2019
@dbkr
Copy link
Member Author

dbkr commented Jul 5, 2019

Broke in matrix-org/matrix-js-sdk#974

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Jul 5, 2019
@dbkr
Fix exception whilst syncing
093f139 
event.getPushRules() may return null (for better or worse...).
Use client.getPushRulesForEvent which will calculate them if they
haven't already been calculated.

Fixes element-hq/element-web#10269
@dbkr dbkr mentioned this issue Jul 5, 2019
Merged
@dbkr dbkr moved this from In Progress to In Review in Web App Team Jul 5, 2019
Web App Team automation moved this from In Review to In Test Jul 5, 2019
RiotRobot pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Jul 8, 2019
@dbkr @RiotRobot
Fix exception whilst syncing
81c6023 
event.getPushRules() may return null (for better or worse...).
Use client.getPushRulesForEvent which will calculate them if they
haven't already been calculated.

Fixes element-hq/element-web#10269
@jryans jryans moved this from In Test to Done in Web App Team Jul 8, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 21, 2023
@su-ex
Merge tag 'v1.11.29' into sc
f88e48a 
* Allow desktop app to expose recent rooms in UI integrations ([\element-hq#16940](element-hq#16940)).
* Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#24820](element-hq#24820)). Contributed by @dhenneke.
* Style mentions as pills in rich text editor ([\element-hq#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner.
* Show room create icon if "UIComponent.roomCreation" is enabled ([\element-hq#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk.
* Mentions as links rte ([\element-hq#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner.
* Better error handling in jump to date ([\element-hq#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods.
* Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\element-hq#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk.
* Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\element-hq#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq#10559.
* Mentions as links rte ([\element-hq#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner.
* Implement MSC3952: intentional mentions ([\element-hq#9983](matrix-org/matrix-react-sdk#9983)).
* Implement MSC3973: Search users in the user directory with the Widget API ([\element-hq#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke.
* Permalinks to message are now displayed as pills ([\element-hq#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq#24751 and element-hq#24706.
* Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\element-hq#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk.
* Increase space panel collapse clickable area ([\element-hq#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq#17379. Contributed by @jaiwanth-v.
* Add fallback for replies to Polls ([\element-hq#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq#24197. Contributed by @kerryarchibald.
* Permalinks to rooms and users are now pillified ([\element-hq#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq#24825.
* Poll history -  access poll history from room settings ([\element-hq#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald.
* Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke.
* Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald.
* Support dynamic room predecessor in SpaceProvider ([\element-hq#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam.
* Support dynamic room predecessors for RoomProvider ([\element-hq#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam.
* Support dynamic room predecessors in OwnBeaconStore ([\element-hq#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam.
* Support dynamic room predecessors in ForwardDialog ([\element-hq#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam.
* Support dynamic room predecessors in SpaceHierarchy ([\element-hq#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam.
* Support dynamic room predecessors in AddExistingToSpaceDialog ([\element-hq#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam.
* Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam.
* Support dynamic room predecessors in StopGapWidgetDriver ([\element-hq#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam.
* Support dynamic room predecessors in WidgetLayoutStore ([\element-hq#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam.
* Support dynamic room predecessors in SpaceStore ([\element-hq#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam.
* Sync polls push rules on changes to account_data ([\element-hq#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald.
* Support dynamic room predecessors in BreadcrumbsStore ([\element-hq#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam.
* Improved a11y for Field feedback and Secure Phrase input ([\element-hq#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones.
* Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam.
* Use a newly generated access_token while joining Jitsi ([\element-hq#24646](element-hq#24646)). Fixes element-hq#24687. Contributed by @emrahcom.
* Fix cloudflare action pointing at commit hash instead of tag ([\element-hq#24777](element-hq#24777)). Contributed by @justjanne.
* Allow editing with RTE to overflow for autocomplete visibility ([\element-hq#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner.
* Added auto focus to Github URL on opening of debug logs modal ([\element-hq#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm.
* Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq#24995.
* Properly generate mentions when editing a reply with MSC3952 ([\element-hq#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq#24924. Contributed by @kerryarchibald.
* Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam.
* Prevent future date selection in jump to date ([\element-hq#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq#20800. Contributed by @MadLittleMods.
* Add aria labels to message search bar to improve accessibility ([\element-hq#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq#24921.
* Fix decryption failure bar covering the timeline ([\element-hq#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq#24780 element-hq#24074 and element-hq#24183. Contributed by @luixxiul.
* Improve profile picture settings accessibility ([\element-hq#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq#24919.
* Handle group call redaction ([\element-hq#10465](matrix-org/matrix-react-sdk#10465)).
* Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq#24841. Contributed by @kerryarchibald.
* Fix timeline list and paragraph display issues ([\element-hq#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq#24602. Contributed by @alunturner.
* Use unique keys for voice broadcast pips ([\element-hq#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq#24959.
* Fix "show read receipts sent by other users" not applying to threads ([\element-hq#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq#24910.
* Fix joining public rooms without aliases in search dialog ([\element-hq#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq#23937.
* Add input validation for `m.direct` in `DMRoomMap` ([\element-hq#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq#24909.
* Reduce height reserved for "collapse" button's line on IRC layout ([\element-hq#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq#24605. Contributed by @luixxiul.
* Fix `creatorUserId is required` error when opening sticker picker ([\element-hq#10423](matrix-org/matrix-react-sdk#10423)).
* Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\element-hq#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods.
* Fix profile resizer to make first character of a line selectable in IRC layout ([\element-hq#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq#14764. Contributed by @luixxiul.
* Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq#24742. Contributed by @luixxiul.
* Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\element-hq#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods.
* Fix big date separators when jump to date is enabled ([\element-hq#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq#22969. Contributed by @MadLittleMods.
* Fixes user authentication when registering via the module API ([\element-hq#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk.
* Handle more edge cases in Space Hierarchy ([\element-hq#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne.
* Further improve performance with lots of hidden events ([\element-hq#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq#24480. Contributed by @andybalaam.
* Respect user cancelling upload flow by dismissing spinner ([\element-hq#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq#24667.
* When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\element-hq#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq#24397.
* Fix `[object Object]` in feedback metadata ([\element-hq#10390](matrix-org/matrix-react-sdk#10390)).
* Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq#24615.
* Fix import e2e key dialog staying disabled after paste ([\element-hq#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq#24818.
* Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\element-hq#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq#24813.
* Fix UIFeature.Registration not applying to all paths ([\element-hq#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq#24814.
* Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\element-hq#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq#24797.
* Fix start DM with pending third party invite ([\element-hq#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq#24781.
* Fix long display name overflowing reply tile on IRC layout ([\element-hq#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq#24738. Contributed by @luixxiul.
* Display redacted body on ThreadView in the same way as normal messages ([\element-hq#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq#24729. Contributed by @luixxiul.
* Handle more edge cases in ACL updates ([\element-hq#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne.
* Allow parsing png files to fail if thumbnailing is successful ([\element-hq#10308](matrix-org/matrix-react-sdk#10308)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
P1 T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix exception whilst syncing matrix-org/matrix-js-sdk
3 participants
@jryans @dbkr @erikjohnston