Fix profile resizer to make first character of a line selectable in IRC layout #10396

luixxiul · 2023-03-16T19:38:50Z

This PR intends to fix the issue that the first character of a line in IRC layout cannot be selected by replacing the hard-coded inline inset value of mx_ProfileResizer with a variable. The issue may be specific to the desktop app for Linux distros (see: element-hq/element-web#14764 (comment); the issue is reproduced on Debian for me).

To improve accessibility, it is possible to move the resizer a little bit (~5px?) to the left side by setting - var(--resizer-a11y) with --resizer-a11y: 5px. Let me know if such spacing should be added.

Fixes element-hq/element-web#14764

Before	After
The resizer overlaps the first character etc.

type: defect

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

Fix profile resizer to make first character of a line selectable in IRC layout (#10396). Fixes Cannot select first character of line in IRC mode element-hq/element-web#14764. Contributed by @luixxiul.

…C layout Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

luixxiul · 2023-03-16T19:48:18Z

In fact, moving even 3px feels like a11y improvement for me. You could test it locally by setting left: calc(70px + var(--name-width)) via ~~browser's~~ Electron's devtool.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

luixxiul · 2023-03-16T20:16:06Z

cypress/e2e/timeline/timeline.spec.ts

+                // --resizer-width = 15px
+                // 18px + 46px + 14px + 5px + 80px + 5px - 15px
+                // = 153px
+                cy.get(".mx_ProfileResizer").should("have.css", "inset-inline-start", "153px");


Since the resizer is transparent, it is not possible to use a screenshot test to detect a regression.

luixxiul · 2023-03-16T20:17:28Z

@florianduros Would you please review when you have some time? Thanks in advance.

res/css/views/rooms/_IRCLayout.pcss

florianduros · 2023-03-17T10:04:50Z

Also I tried to put left: calc(70px + var(--name-width)) to the mx_ProfileResizer but I didn't see any visible differences. I'am missing something ?

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

luixxiul · 2023-03-17T15:25:40Z

I didn't see any visible differences.

Maybe the issue is specific to XFCE desktop. It is not reproduced on the browser on the desktop environment (I'm sorry for the wrong comment here: #10396 (comment)).

The change should make it less difficult to avoid selecting the resizer when you try to select the text from right to left. Here is the comparison:

With 73px, zero spacing between the resizer and the first character (blue area is the resizer):

73px.mp4

With 70px, 3px spacing between them:

70px.mp4

There is another issue that dragging over the resizer selects all texts above, but it is out of scope of this PR.

florianduros

Better without the ignore rule, thank @luixxiul !

About the extra 3px, I think that's a good idea to improve the usability. Do you want to do it in this PR (which is improving the use case of your fix) ?

Otherwise, If you want to keep the PR in this current state, I'm ok to merge it.

luixxiul · 2023-03-20T14:43:24Z

About the extra 3px, I think that's a good idea to improve the usability. Do you want to do it in this PR (which is improving the use case of your fix) ?

Yes, I'm adding the 3px with this PR. Please wait for a moment..

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

florianduros

Great, thank for your contribution !

luixxiul · 2023-03-21T15:10:02Z

Thanks for the review!

@dhenneke

* Ship linux tarball with static sqlcipher ([\element-hq#597](element-hq#597)). Fixes element-hq/element-web#18486. * Show recent room breadcrumbs on touchbar ([\element-hq#183](element-hq#183)). Fixes element-hq/element-web#15998. * Clear electron data when logging out ([\element-hq#578](element-hq#578)). * Send Electron crashpad reports to Sentry from Nightly ([\element-hq#579](element-hq#579)). Fixes element-hq/element-web#18263. * Recommend element-io-archive-keyring from our Debian package ([\element-hq#566](element-hq#566)). * Allow desktop app to expose recent rooms in UI integrations ([\#16940](element-hq/element-web#16940)). * Add API params to mute audio and/or video in Jitsi calls by default ([\#24820](element-hq/element-web#24820)). Contributed by @dhenneke. * Style mentions as pills in rich text editor ([\#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk. * Mentions as links rte ([\#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq/element-web#10559. * Mentions as links rte ([\#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\#9983](matrix-org/matrix-react-sdk#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq/element-web#24751 and element-hq/element-web#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq/element-web#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq/element-web#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq/element-web#24825. * Poll history - access poll history from room settings ([\#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam. * Run build_linux in docker using an older glibc ([\element-hq#599](element-hq#599)). Fixes element-hq/element-web#24981. * Use a newly generated access_token while joining Jitsi ([\#24646](element-hq/element-web#24646)). Fixes element-hq/element-web#24687. Contributed by @emrahcom. * Fix cloudflare action pointing at commit hash instead of tag ([\#24777](element-hq/element-web#24777)). Contributed by @justjanne. * Allow editing with RTE to overflow for autocomplete visibility ([\#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq/element-web#24995. * Properly generate mentions when editing a reply with MSC3952 ([\#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq/element-web#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq/element-web#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq/element-web#24921. * Fix decryption failure bar covering the timeline ([\#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq/element-web#24780 element-hq/element-web#24074 and element-hq/element-web#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq/element-web#24919. * Handle group call redaction ([\#10465](matrix-org/matrix-react-sdk#10465)). * Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq/element-web#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq/element-web#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq/element-web#24959. * Fix "show read receipts sent by other users" not applying to threads ([\#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq/element-web#24910. * Fix joining public rooms without aliases in search dialog ([\#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq/element-web#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq/element-web#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq/element-web#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\#10423](matrix-org/matrix-react-sdk#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq/element-web#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq/element-web#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq/element-web#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq/element-web#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq/element-web#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq/element-web#24397. * Fix `[object Object]` in feedback metadata ([\#10390](matrix-org/matrix-react-sdk#10390)). * Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq/element-web#24615. * Fix import e2e key dialog staying disabled after paste ([\#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq/element-web#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq/element-web#24813. * Fix UIFeature.Registration not applying to all paths ([\#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq/element-web#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq/element-web#24797. * Fix start DM with pending third party invite ([\#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq/element-web#24781. * Fix long display name overflowing reply tile on IRC layout ([\#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq/element-web#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq/element-web#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\#10308](matrix-org/matrix-react-sdk#10308)).

@dhenneke

* Allow desktop app to expose recent rooms in UI integrations ([\element-hq#16940](element-hq#16940)). * Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#24820](element-hq#24820)). Contributed by @dhenneke. * Style mentions as pills in rich text editor ([\element-hq#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\element-hq#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk. * Mentions as links rte ([\element-hq#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\element-hq#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\element-hq#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\element-hq#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq#10559. * Mentions as links rte ([\element-hq#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\element-hq#9983](matrix-org/matrix-react-sdk#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\element-hq#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\element-hq#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq#24751 and element-hq#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\element-hq#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\element-hq#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\element-hq#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\element-hq#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq#24825. * Poll history - access poll history from room settings ([\element-hq#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\element-hq#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\element-hq#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\element-hq#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\element-hq#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\element-hq#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\element-hq#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\element-hq#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\element-hq#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\element-hq#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\element-hq#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\element-hq#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\element-hq#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam. * Use a newly generated access_token while joining Jitsi ([\element-hq#24646](element-hq#24646)). Fixes element-hq#24687. Contributed by @emrahcom. * Fix cloudflare action pointing at commit hash instead of tag ([\element-hq#24777](element-hq#24777)). Contributed by @justjanne. * Allow editing with RTE to overflow for autocomplete visibility ([\element-hq#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\element-hq#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq#24995. * Properly generate mentions when editing a reply with MSC3952 ([\element-hq#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\element-hq#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\element-hq#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq#24921. * Fix decryption failure bar covering the timeline ([\element-hq#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq#24780 element-hq#24074 and element-hq#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\element-hq#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq#24919. * Handle group call redaction ([\element-hq#10465](matrix-org/matrix-react-sdk#10465)). * Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\element-hq#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\element-hq#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq#24959. * Fix "show read receipts sent by other users" not applying to threads ([\element-hq#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq#24910. * Fix joining public rooms without aliases in search dialog ([\element-hq#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\element-hq#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\element-hq#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\element-hq#10423](matrix-org/matrix-react-sdk#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\element-hq#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\element-hq#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\element-hq#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\element-hq#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\element-hq#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\element-hq#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\element-hq#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\element-hq#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\element-hq#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq#24397. * Fix `[object Object]` in feedback metadata ([\element-hq#10390](matrix-org/matrix-react-sdk#10390)). * Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq#24615. * Fix import e2e key dialog staying disabled after paste ([\element-hq#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\element-hq#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq#24813. * Fix UIFeature.Registration not applying to all paths ([\element-hq#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\element-hq#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq#24797. * Fix start DM with pending third party invite ([\element-hq#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq#24781. * Fix long display name overflowing reply tile on IRC layout ([\element-hq#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\element-hq#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\element-hq#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\element-hq#10308](matrix-org/matrix-react-sdk#10308)).

@alunturner

* Style mentions as pills in rich text editor ([\matrix-org#10448](matrix-org#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\matrix-org#10364](matrix-org#10364)). Contributed by @maheichyk. * Mentions as links rte ([\matrix-org#10463](matrix-org#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\matrix-org#10405](matrix-org#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\matrix-org#10363](matrix-org#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\matrix-org#10425](matrix-org#10425)). Fixes element-hq/element-web#10559. * Mentions as links rte ([\matrix-org#10422](matrix-org#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\matrix-org#9983](matrix-org#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\matrix-org#10269](matrix-org#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\matrix-org#10392](matrix-org#10392)). Fixes element-hq/element-web#24751 and element-hq/element-web#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\matrix-org#10381](matrix-org#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\matrix-org#6084](matrix-org#6084)). Fixes element-hq/element-web#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\matrix-org#10380](matrix-org#10380)). Fixes element-hq/element-web#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\matrix-org#10388](matrix-org#10388)). Fixes element-hq/element-web#24825. * Poll history - access poll history from room settings ([\matrix-org#10356](matrix-org#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\matrix-org#10376](matrix-org#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\matrix-org#10288](matrix-org#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\matrix-org#10348](matrix-org#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\matrix-org#10346](matrix-org#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\matrix-org#10339](matrix-org#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\matrix-org#10344](matrix-org#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\matrix-org#10341](matrix-org#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\matrix-org#10342](matrix-org#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\matrix-org#10340](matrix-org#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\matrix-org#10338](matrix-org#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\matrix-org#10326](matrix-org#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\matrix-org#10332](matrix-org#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\matrix-org#10287](matrix-org#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\matrix-org#10295](matrix-org#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\matrix-org#10320](matrix-org#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\matrix-org#10297](matrix-org#10297)). Contributed by @andybalaam. * Allow editing with RTE to overflow for autocomplete visibility ([\matrix-org#10499](matrix-org#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\matrix-org#10479](matrix-org#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\matrix-org#10487](matrix-org#10487)). Fixes element-hq/element-web#24995. * Properly generate mentions when editing a reply with MSC3952 ([\matrix-org#10486](matrix-org#10486)). Fixes element-hq/element-web#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\matrix-org#10131](matrix-org#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\matrix-org#10419](matrix-org#10419)). Fixes element-hq/element-web#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\matrix-org#10476](matrix-org#10476)). Fixes element-hq/element-web#24921. * Fix decryption failure bar covering the timeline ([\matrix-org#10360](matrix-org#10360)). Fixes element-hq/element-web#24780 element-hq/element-web#24074 and element-hq/element-web#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\matrix-org#10470](matrix-org#10470)). Fixes element-hq/element-web#24919. * Handle group call redaction ([\matrix-org#10465](matrix-org#10465)). * Display relative timestamp for threads on the same calendar day ([\matrix-org#10399](matrix-org#10399)). Fixes element-hq/element-web#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\matrix-org#10424](matrix-org#10424)). Fixes element-hq/element-web#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\matrix-org#10457](matrix-org#10457)). Fixes element-hq/element-web#24959. * Fix "show read receipts sent by other users" not applying to threads ([\matrix-org#10445](matrix-org#10445)). Fixes element-hq/element-web#24910. * Fix joining public rooms without aliases in search dialog ([\matrix-org#10437](matrix-org#10437)). Fixes element-hq/element-web#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\matrix-org#10436](matrix-org#10436)). Fixes element-hq/element-web#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\matrix-org#10211](matrix-org#10211)). Fixes element-hq/element-web#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\matrix-org#10423](matrix-org#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\matrix-org#10412](matrix-org#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\matrix-org#10396](matrix-org#10396)). Fixes element-hq/element-web#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\matrix-org#10188](matrix-org#10188)). Fixes element-hq/element-web#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\matrix-org#10402](matrix-org#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\matrix-org#10404](matrix-org#10404)). Fixes element-hq/element-web#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\matrix-org#10257](matrix-org#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\matrix-org#10280](matrix-org#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\matrix-org#10353](matrix-org#10353)). Fixes element-hq/element-web#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\matrix-org#10373](matrix-org#10373)). Fixes element-hq/element-web#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\matrix-org#10394](matrix-org#10394)). Fixes element-hq/element-web#24397. * Fix `[object Object]` in feedback metadata ([\matrix-org#10390](matrix-org#10390)). * Fix pinned messages card saying nothing pinned while loading ([\matrix-org#10385](matrix-org#10385)). Fixes element-hq/element-web#24615. * Fix import e2e key dialog staying disabled after paste ([\matrix-org#10375](matrix-org#10375)). Fixes element-hq/element-web#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\matrix-org#10369](matrix-org#10369)). Fixes element-hq/element-web#24813. * Fix UIFeature.Registration not applying to all paths ([\matrix-org#10371](matrix-org#10371)). Fixes element-hq/element-web#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\matrix-org#10359](matrix-org#10359)). Fixes element-hq/element-web#24797. * Fix start DM with pending third party invite ([\matrix-org#10347](matrix-org#10347)). Fixes element-hq/element-web#24781. * Fix long display name overflowing reply tile on IRC layout ([\matrix-org#10343](matrix-org#10343)). Fixes element-hq/element-web#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\matrix-org#9016](matrix-org#9016)). Fixes element-hq/element-web#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\matrix-org#10279](matrix-org#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\matrix-org#10308](matrix-org#10308)).

@alunturner

Changes in [1.11.30](https://github.com/vector-im/element-web/releases/tag/v1.11.30) (2023-04-25) ================================================================================================= ## 🔒 Security * Fixes for [CVE-2023-30609](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE-2023-30609) / GHSA-xv83-x443-7rmw ## ✨ Features * Pick sensible default option for phone country dropdown ([\#10627](matrix-org/matrix-react-sdk#10627)). Fixes #3528. * Relate field validation tooltip via aria-describedby ([\#10522](matrix-org/matrix-react-sdk#10522)). Fixes #24963. * Handle more completion types in rte autocomplete ([\#10560](matrix-org/matrix-react-sdk#10560)). Contributed by @alunturner. * Show a tile for an unloaded predecessor room if it has via_servers ([\#10483](matrix-org/matrix-react-sdk#10483)). Contributed by @andybalaam. * Exclude message timestamps from aria live region ([\#10584](matrix-org/matrix-react-sdk#10584)). Fixes #5696. * Make composer format bar an aria toolbar ([\#10583](matrix-org/matrix-react-sdk#10583)). Fixes #11283. * Improve accessibility of font slider ([\#10473](matrix-org/matrix-react-sdk#10473)). Fixes #20168 and #24962. * fix file size display from kB to KB ([\#10561](matrix-org/matrix-react-sdk#10561)). Fixes #24866. Contributed by @NSV1991. * Handle /me in rte ([\#10558](matrix-org/matrix-react-sdk#10558)). Contributed by @alunturner. * bind html with switch for manage extension setting option ([\#10553](matrix-org/matrix-react-sdk#10553)). Contributed by @NSV1991. * Handle command completions in RTE ([\#10521](matrix-org/matrix-react-sdk#10521)). Contributed by @alunturner. * Add room and user avatars to rte ([\#10497](matrix-org/matrix-react-sdk#10497)). Contributed by @alunturner. * Support for MSC3882 revision 1 ([\#10443](matrix-org/matrix-react-sdk#10443)). Contributed by @hughns. * Check profiles before starting a DM ([\#10472](matrix-org/matrix-react-sdk#10472)). Fixes #24830. * Quick settings: Change the copy / labels on the options ([\#10427](matrix-org/matrix-react-sdk#10427)). Fixes #24522. Contributed by @justjanne. * Update rte autocomplete styling ([\#10503](matrix-org/matrix-react-sdk#10503)). Contributed by @alunturner. ## 🐛 Bug Fixes * Fix create subspace dialog not working ([\#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq/element-web#24882 * Fix multiple accessibility defects identified by AXE ([\#10606](matrix-org/matrix-react-sdk#10606)). * Fix view source from edit history dialog always showing latest event ([\#10626](matrix-org/matrix-react-sdk#10626)). Fixes #21859. * #21451 Fix WebGL disabled error message ([\#10589](matrix-org/matrix-react-sdk#10589)). Contributed by @rashmitpankhania. * Properly translate errors in `AddThreepid.ts` so they show up translated to the user but not in our logs ([\#10432](matrix-org/matrix-react-sdk#10432)). Contributed by @MadLittleMods. * Fix overflow on auth pages ([\#10605](matrix-org/matrix-react-sdk#10605)). Fixes #19548. * Fix incorrect avatar background colour when using a custom theme ([\#10598](matrix-org/matrix-react-sdk#10598)). Contributed by @jdauphant. * Remove dependency on `org.matrix.e2e_cross_signing` unstable feature ([\#10593](matrix-org/matrix-react-sdk#10593)). * Update setting description to match reality ([\#10600](matrix-org/matrix-react-sdk#10600)). Fixes #25106. * Fix no identity server in help & about settings ([\#10563](matrix-org/matrix-react-sdk#10563)). Fixes #25077. * Fix: Images no longer reserve their space in the timeline correctly ([\#10571](matrix-org/matrix-react-sdk#10571)). Fixes #25082. Contributed by @kerryarchibald. * Fix issues with inhibited accessible focus outlines ([\#10579](matrix-org/matrix-react-sdk#10579)). Fixes #19742. * Fix read receipts falling from sky ([\#10576](matrix-org/matrix-react-sdk#10576)). Fixes #25081. * Fix avatar text issue in rte ([\#10559](matrix-org/matrix-react-sdk#10559)). Contributed by @alunturner. * fix resizer only work with left mouse click ([\#10546](matrix-org/matrix-react-sdk#10546)). Contributed by @NSV1991. * Fix send two join requests when joining a room from spotlight search ([\#10534](matrix-org/matrix-react-sdk#10534)). Fixes #25054. * Highlight event when any version triggered a highlight ([\#10502](matrix-org/matrix-react-sdk#10502)). Fixes #24923 and #24970. Contributed by @kerryarchibald. * Fix spacing of headings of integration manager on General settings tab ([\#10232](matrix-org/matrix-react-sdk#10232)). Fixes #24085. Contributed by @luixxiul. Changes in [1.11.29](https://github.com/vector-im/element-web/releases/tag/v1.11.29) (2023-04-11) ================================================================================================= ## ✨ Features * Allow desktop app to expose recent rooms in UI integrations ([\#16940](element-hq/element-web#16940)). * Add API params to mute audio and/or video in Jitsi calls by default ([\#24820](element-hq/element-web#24820)). Contributed by @dhenneke. * Style mentions as pills in rich text editor ([\#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk. * Mentions as links rte ([\#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\#10425](matrix-org/matrix-react-sdk#10425)). Fixes #10559. * Mentions as links rte ([\#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\#9983](matrix-org/matrix-react-sdk#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\#10392](matrix-org/matrix-react-sdk#10392)). Fixes #24751 and #24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\#6084](matrix-org/matrix-react-sdk#6084)). Fixes #17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\#10380](matrix-org/matrix-react-sdk#10380)). Fixes #24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\#10388](matrix-org/matrix-react-sdk#10388)). Fixes #24825. * Poll history - access poll history from room settings ([\#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam. ## 🐛 Bug Fixes * Use a newly generated access_token while joining Jitsi ([\#24646](element-hq/element-web#24646)). Fixes #24687. Contributed by @emrahcom. * Fix cloudflare action pointing at commit hash instead of tag ([\#24777](element-hq/element-web#24777)). Contributed by @justjanne. * Allow editing with RTE to overflow for autocomplete visibility ([\#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes #24995. * Properly generate mentions when editing a reply with MSC3952 ([\#10486](matrix-org/matrix-react-sdk#10486)). Fixes #24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\#10419](matrix-org/matrix-react-sdk#10419)). Fixes #20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\#10476](matrix-org/matrix-react-sdk#10476)). Fixes #24921. * Fix decryption failure bar covering the timeline ([\#10360](matrix-org/matrix-react-sdk#10360)). Fixes #24780 #24074 and #24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\#10470](matrix-org/matrix-react-sdk#10470)). Fixes #24919. * Handle group call redaction ([\#10465](matrix-org/matrix-react-sdk#10465)). * Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes #24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\#10424](matrix-org/matrix-react-sdk#10424)). Fixes #24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\#10457](matrix-org/matrix-react-sdk#10457)). Fixes #24959. * Fix "show read receipts sent by other users" not applying to threads ([\#10445](matrix-org/matrix-react-sdk#10445)). Fixes #24910. * Fix joining public rooms without aliases in search dialog ([\#10437](matrix-org/matrix-react-sdk#10437)). Fixes #23937. * Add input validation for `m.direct` in `DMRoomMap` ([\#10436](matrix-org/matrix-react-sdk#10436)). Fixes #24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\#10211](matrix-org/matrix-react-sdk#10211)). Fixes #24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\#10423](matrix-org/matrix-react-sdk#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\#10396](matrix-org/matrix-react-sdk#10396)). Fixes #14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes #24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\#10404](matrix-org/matrix-react-sdk#10404)). Fixes #22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\#10353](matrix-org/matrix-react-sdk#10353)). Fixes #24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\#10373](matrix-org/matrix-react-sdk#10373)). Fixes #24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\#10394](matrix-org/matrix-react-sdk#10394)). Fixes #24397. * Fix `[object Object]` in feedback metadata ([\#10390](matrix-org/matrix-react-sdk#10390)). * Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes #24615. * Fix import e2e key dialog staying disabled after paste ([\#10375](matrix-org/matrix-react-sdk#10375)). Fixes #24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\#10369](matrix-org/matrix-react-sdk#10369)). Fixes #24813. * Fix UIFeature.Registration not applying to all paths ([\#10371](matrix-org/matrix-react-sdk#10371)). Fixes #24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\#10359](matrix-org/matrix-react-sdk#10359)). Fixes #24797. * Fix start DM with pending third party invite ([\#10347](matrix-org/matrix-react-sdk#10347)). Fixes #24781. * Fix long display name overflowing reply tile on IRC layout ([\#10343](matrix-org/matrix-react-sdk#10343)). Fixes #24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\#9016](matrix-org/matrix-react-sdk#9016)). Fixes #24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\#10308](matrix-org/matrix-react-sdk#10308)).

luixxiul added 2 commits March 17, 2023 04:32

Replace the magic number for the profile resizer with variables on IR…

2367498

…C layout Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Add a test

6eb76e9

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Mar 16, 2023

github-actions bot deployed to Netlify March 16, 2023 19:43 View deployment

lint

0f8f9a6

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

github-actions bot deployed to Netlify March 16, 2023 19:57 View deployment

luixxiul marked this pull request as ready for review March 16, 2023 20:14

luixxiul requested a review from a team as a code owner March 16, 2023 20:14

luixxiul requested review from richvdh and florianduros March 16, 2023 20:14

luixxiul commented Mar 16, 2023

View reviewed changes

florianduros requested changes Mar 17, 2023

View reviewed changes

res/css/views/rooms/_IRCLayout.pcss Outdated Show resolved Hide resolved

Remove the deprecated rules

d796bf7

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

github-actions bot deployed to Netlify March 17, 2023 15:04 View deployment

florianduros self-requested a review March 20, 2023 13:51

florianduros reviewed Mar 20, 2023

View reviewed changes

luixxiul added 3 commits March 21, 2023 01:00

Add --resizer-a11y 3px

8a31cb1

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Merge branch 'develop' into fix-irc-ProfileResizer

c7a5abd

Merge branch 'develop' into fix-irc-ProfileResizer

f32f0c9

github-actions bot deployed to Netlify March 20, 2023 16:10 View deployment

Merge branch 'develop' into fix-irc-ProfileResizer

2fe0a93

github-actions bot deployed to Netlify March 20, 2023 16:58 View deployment

Fix the declaration

4146859

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

github-actions bot deployed to Netlify March 20, 2023 17:28 View deployment

luixxiul requested review from florianduros and removed request for richvdh March 20, 2023 17:55

florianduros approved these changes Mar 21, 2023

View reviewed changes

florianduros merged commit d8acdd1 into matrix-org:develop Mar 21, 2023

luixxiul deleted the fix-irc-ProfileResizer branch March 21, 2023 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix profile resizer to make first character of a line selectable in IRC layout #10396

Fix profile resizer to make first character of a line selectable in IRC layout #10396

luixxiul commented Mar 16, 2023 •

edited by github-actions bot

Loading

luixxiul commented Mar 16, 2023 •

edited

Loading

luixxiul Mar 16, 2023

luixxiul commented Mar 16, 2023

florianduros commented Mar 17, 2023

luixxiul commented Mar 17, 2023 •

edited

Loading

florianduros left a comment •

edited

Loading

luixxiul commented Mar 20, 2023

florianduros left a comment

luixxiul commented Mar 21, 2023

Fix profile resizer to make first character of a line selectable in IRC layout #10396

Fix profile resizer to make first character of a line selectable in IRC layout #10396

Conversation

luixxiul commented Mar 16, 2023 • edited by github-actions bot Loading

Checklist

🐛 Bug Fixes

luixxiul commented Mar 16, 2023 • edited Loading

luixxiul Mar 16, 2023

Choose a reason for hiding this comment

luixxiul commented Mar 16, 2023

florianduros commented Mar 17, 2023

luixxiul commented Mar 17, 2023 • edited Loading

florianduros left a comment • edited Loading

Choose a reason for hiding this comment

luixxiul commented Mar 20, 2023

florianduros left a comment

Choose a reason for hiding this comment

luixxiul commented Mar 21, 2023

luixxiul commented Mar 16, 2023 •

edited by github-actions bot

Loading

luixxiul commented Mar 16, 2023 •

edited

Loading

luixxiul commented Mar 17, 2023 •

edited

Loading

florianduros left a comment •

edited

Loading