Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector attempts to load thumbnail for SVGs, but Synapse does not support SVG "thumbnailing". #1341

Closed
aviraldg opened this issue Apr 2, 2016 · 3 comments · Fixed by matrix-org/matrix-react-sdk#1865
Closed

Vector attempts to load thumbnail for SVGs, but Synapse does not support SVG "thumbnailing". #1341

aviraldg opened this issue Apr 2, 2016 · 3 comments · Fixed by matrix-org/matrix-react-sdk#1865
Labels
P2 T-Enhancement

Comments

@aviraldg
Copy link
Contributor

aviraldg commented Apr 2, 2016

As described, plus it does not make sense to generate thumbnails for SVG.
aviraldg added a commit to aviraldg/matrix-react-sdk that referenced this issue Apr 2, 2016
@aviraldg
Load original image, not thumbnail, if it's an SVG
6caec58 
fixes element-hq/element-web#1341
@aviraldg aviraldg mentioned this issue Apr 2, 2016
Closed
@ara4n
Copy link
Member

ara4n commented Apr 2, 2016

This is more a Synapse bug - https://matrix.org/jira/browse/SYN-344, and I'm afraid I coincidentally fixed it last night in Synapse in: matrix-org/synapse@2c838f6 - sorry!

@ara4n ara4n closed this as completed Apr 2, 2016
@ara4n
Copy link
Member

ara4n commented Apr 14, 2016

Had to back this out in matrix-org/synapse@bd77216

@ara4n ara4n reopened this Apr 14, 2016
@richvdh richvdh mentioned this issue Aug 25, 2016
Open
ara4n added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 29, 2018
@ara4n
fix ugly img errors and correctly render SVG thumbnails
c254d04 
Fixes element-hq/element-web#6271
Fixes element-hq/element-web#1341
@ara4n ara4n mentioned this issue Apr 29, 2018
Merged
@ara4n
Copy link
Member

ara4n commented Apr 30, 2018

this has been fixed by using the clientside-generated thumbnail (if one exists)

@ara4n ara4n closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Enhancement
Projects
None yet
Milestone
No milestone
3 participants
@aviraldg @jryans @ara4n