Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "When rooms are upgraded > On" in Settings > Notifications does not work #15439

Closed
Half-Shot opened this issue Oct 12, 2020 · 6 comments · Fixed by matrix-org/matrix-js-sdk#2376
Closed

Clicking "When rooms are upgraded > On" in Settings > Notifications does not work #15439

Half-Shot opened this issue Oct 12, 2020 · 6 comments · Fixed by matrix-org/matrix-js-sdk#2376
Assignees
@turt2live
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-FTUE-Notifications

Comments

@Half-Shot
Copy link
Member

Half-Shot commented Oct 12, 2020 •
edited by MadLittleMods
Loading

The allowed values of Settings -> Notifications -> When rooms are upgraded appear to be "Off" and "Noisy". Clicking "On" when "Off" will cause the notifications to be noisy.

If room upgrades cannot be "On", we should remove the option. If they can, we should fix the bug.
@t3chguy
Copy link
Member

t3chguy commented Oct 12, 2020

This issue will be going away with the new notifications apis

@t3chguy t3chguy self-assigned this Oct 12, 2020
@turt2live turt2live added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Oct 13, 2020
@jaller94
Copy link
Contributor

jaller94 commented Feb 2, 2021

@turt2live This does not actually seem p1 severity: major, if it hasn't been worked on since October.
I just ran into this in Element Web Stable. The issue is still around.

If it has been accidentally forgotten, here's a ping.

@turt2live
Copy link
Member

Priority and severity don't dictate time in our issue tracker, sorry.

@jryans jryans added the defect label Feb 24, 2021
@jryans jryans removed the defect label Mar 4, 2021
@MadLittleMods
Copy link
Contributor

MadLittleMods commented Apr 27, 2022 •
edited
Loading

This issue will be going away with the new notifications apis

-- #15439 (comment)

@Half-Shot Can you still reproduce this issue now that I assume the new notification API's are deployed?

@MadLittleMods MadLittleMods added A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P1 labels Apr 27, 2022
@robintown
Copy link
Member

The new notification APIs were part of the FTUE Notifications project that got put on hold, so they haven't happened yet

@turt2live
Copy link
Member

So it does work - the UI is just wrong. I wonder if that's what's causing #10500

@turt2live turt2live assigned turt2live and unassigned t3chguy May 17, 2022
This was referenced May 17, 2022
Merged
Open
Open
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue May 28, 2022
@su-ex
Merge tag 'v18.0.0' into sc
4a5ee08 
* Implement changes to MSC2285 (private read receipts) ([\matrix-org#2221](matrix-org#2221)).
* Add support for HTML renderings of room topics ([\matrix-org#2272](matrix-org#2272)).
* Add stopClient parameter to MatrixClient::logout ([\matrix-org#2367](matrix-org#2367)).
* registration: add function to re-request email token ([\matrix-org#2357](matrix-org#2357)).
* Remove hacky custom status feature ([\matrix-org#2350](matrix-org#2350)).
* Remove default push rule override for MSC1930 ([\matrix-org#2376](matrix-org#2376)). Fixes element-hq/element-web#15439.
* Tweak thread creation & event adding to fix bugs around relations ([\matrix-org#2369](matrix-org#2369)). Fixes element-hq/element-web#22162 and element-hq/element-web#22180.
* Prune both clear & wire content on redaction ([\matrix-org#2346](matrix-org#2346)). Fixes element-hq/element-web#21929.
* MSC3786: Add a default push rule to ignore `m.room.server_acl` events ([\matrix-org#2333](matrix-org#2333)). Fixes element-hq/element-web#20788.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-FTUE-Notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove default push rule override for MSC1930 matrix-org/matrix-js-sdk
7 participants
@jryans @MadLittleMods @turt2live @Half-Shot @t3chguy @jaller94 @robintown