Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications contain reply fallback from body #17859

Closed
Sr-Preet opened this issue Jul 2, 2021 · 12 comments · Fixed by matrix-org/matrix-react-sdk#11278
Closed

Notifications contain reply fallback from body #17859

Sr-Preet opened this issue Jul 2, 2021 · 12 comments · Fixed by matrix-org/matrix-react-sdk#11278
Assignees
Labels
A-Notifications A-Replies reply O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@Sr-Preet
Copy link

Sr-Preet commented Jul 2, 2021

There exists user A and user B
User A and User B are logged into element on different machines

Steps-1) As User B send a reply of previous message to User A
As user A - Observe the notification received

Actual result-Matrix id of the user is displayed in the notification of reply

Expected result-Name of the user should be displayed instead of matrix id

Screenshot (6)

@t3chguy t3chguy changed the title Martix id of the user is displayed in the notification of reply Notifications contain reply fallback from body Jul 2, 2021
@t3chguy
Copy link
Member

t3chguy commented Jul 2, 2021

Name of the user should be displayed instead of matrix id

This is unlikely to happen, the Notification is built on the body of the Matrix event being received, that body only contains the ID. This section should be stripped, it is a fallback only for legacy clients.

@t3chguy t3chguy added the A-Replies reply label Jul 2, 2021
@Sr-Preet
Copy link
Author

Sr-Preet commented Jul 2, 2021

@t3chguy
Okay, So what can we do to resolve this.
This is happening on the current element-web as well as my custom build.

@t3chguy
Copy link
Member

t3chguy commented Jul 2, 2021

Notifier needs to gain something akin to stripReplyFallback in HtmlUtils

@Sr-Preet
Copy link
Author

Sr-Preet commented Jul 2, 2021

@t3chguy
Like bodyToHtml?

@t3chguy
Copy link
Member

t3chguy commented Jul 2, 2021

Yeah, might even be able to use that method

@Sr-Preet
Copy link
Author

Sr-Preet commented Jul 2, 2021

@t3chguy
How about this one?
Screenshot (34)
It's working too.

@Sr-Preet
Copy link
Author

Sr-Preet commented Jul 2, 2021

@t3chguy
Can you take a look into this too?[#17860 ]

@t3chguy
Copy link
Member

t3chguy commented Jul 2, 2021

Open a pull request and it'll have to go through review.

@Sr-Preet
Copy link
Author

Sr-Preet commented Jul 2, 2021

@t3chguy Sure

@gabrc52
Copy link

gabrc52 commented May 16, 2023

This is especially annoying when a reply is long enough to take up the whole notification and you can't see the actual message from the notification

@gabrc52
Copy link

gabrc52 commented Jul 17, 2023

Thank you! Has this been fixed on mobile as well?

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2023

@gabrc52 you'd need to ask the repo responsible for the mobile application which you are using. There are tens if not hundreds of mobile Matrix clients available for use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Replies reply O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
4 participants