Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for threads contain the text of the message that the thread was started from #24620

Closed
jrmuizel opened this issue Feb 23, 2023 · 13 comments
Labels
A-Notifications A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation

Comments

@jrmuizel
Copy link

Steps to reproduce

  1. Start a thread
  2. Get replies to the thread

Outcome

What did you expect?

Notifications that contain the text of the reply

What happened instead?

Notifications contain the text of the message that the thread was started from instead of the text of the replies.

Operating system

macOS 10.15

Application version

Version 1.11.23 (1.11.23)

How did you install the app?

No response

Homeserver

mozilla.org

Will you send logs?

Yes

@weeman1337
Copy link
Contributor

@jrmuizel thank you for reporting the issue. This is not related to threads and applies to all replies.

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Feb 23, 2023
@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Feb 23, 2023
@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

@weeman1337 threads don't contain a fallback like replies:

image

Could this be #24336?

@weeman1337
Copy link
Contributor

Could this be #24336?

Closed the other issue, because I cannot reproduce it any more.

@weeman1337

This comment was marked as off-topic.

@weeman1337
Copy link
Contributor

Maybe this should change to „someone replied to“ or „someone $reply message“ 🤷‍♂️

@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

@weeman1337 that's a reply though, not a thread response

#17859 is the isssue tracking what you demonstrate in your screenshot

@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

@jrmuizel can you clarify was it a reply or a thread response? A screenshot would be helpful.

@jrmuizel
Copy link
Author

jrmuizel commented Feb 23, 2023 via email

@jrmuizel
Copy link
Author

jrmuizel commented Mar 2, 2023

This is marked as needing info. Is there still info that's needed?

@t3chguy t3chguy added X-Needs-Investigation and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Mar 7, 2023
@8227846265
Copy link

This bug is RIDICULOUS and SUPER ANNOYING.

You send one message. Element will then barrage you with 5 duplicate notification even though no one replied.

If you sent 5 messages. You get 15+ Duplicate Notification Message!!!

(╯°□°)╯︵ ┻━┻

I sent a rage shake for this. Hopefully someone can see it and help on the necessary info to reproduce this issue.

@8227846265
Copy link

(╯°□°)╯︵ ┻━┻

There's no day to properly message on an encrypted room without this bug being triggered.

@xi-pinmping
Copy link

I seem to be getting this mostly with direct messages to me in a group.

@t3chguy
Copy link
Member

t3chguy commented Jul 21, 2023

I cannot reproduce this anymore, @jrmuizel please shout if you are still seeing it on 1.11.36

@t3chguy t3chguy closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation
Projects
None yet
Development

No branches or pull requests

5 participants