Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve desktop notifications by removing the reply fallback #6605

Closed
wants to merge 33 commits into from
Closed

Improve desktop notifications by removing the reply fallback #6605

wants to merge 33 commits into from

Conversation

Sr-Preet
Copy link

@Sr-Preet Sr-Preet commented Aug 12, 2021

Resolves the issue regarding the desktop notification for replies.
Signed-off-by: Sarpreet ssarpreet.786@gmail.com

Fixes element-hq/element-web#17859


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@Sr-Preet Sr-Preet requested a review from a team as a code owner August 12, 2021 10:11
@turt2live turt2live requested review from turt2live and removed request for a team August 12, 2021 14:06
@turt2live turt2live added the X-Blocked The PR cannot move forward in any capacity until an action is made label Aug 12, 2021
@Sr-Preet
Copy link
Author

@turt2live
Hey Travis,
I hope you're well and safe,
I wanted to ask you if you are still looking into it?

@Palid
Copy link
Contributor

Palid commented Sep 3, 2021

@turt2live can you add some feedback why it's blocked? I can't figure anything out of the comments in here. There's also no issue related to this change, so it doesn't help in reviewing.

@novocaine
Copy link
Contributor

@Sr-Preet can you link to an issue describing what you're solving?

@Palid Palid marked this pull request as draft September 3, 2021 13:26
@Palid
Copy link
Contributor

Palid commented Sep 3, 2021

@Sr-Preet I'm moving this pull request to draft for now. We'd love to understand what was the reasoning for this pull request and what problem does it solve before we do the review, as it seems that those details have been lost somewhere. Can you please link the issue you're trying to solve, or at least describe the problem?

@turt2live turt2live removed their request for review September 3, 2021 13:37
@turt2live turt2live removed the X-Blocked The PR cannot move forward in any capacity until an action is made label Sep 3, 2021
@Sr-Preet Sr-Preet marked this pull request as ready for review September 3, 2021 13:38
@Sr-Preet
Copy link
Author

Sr-Preet commented Sep 8, 2021

@Sr-Preet I'm moving this pull request to draft for now. We'd love to understand what was the reasoning for this pull request and what problem does it solve before we do the review, as it seems that those details have been lost somewhere. Can you please link the issue you're trying to solve, or at least describe the problem?

@Palid @novocaine @turt2live It Fixes element-hq/element-web#17859

@Sr-Preet Sr-Preet closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications contain reply fallback from body
4 participants