-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve desktop notifications by removing the reply fallback #6605
Conversation
eslint changes
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
@turt2live |
@turt2live can you add some feedback why it's blocked? I can't figure anything out of the comments in here. There's also no issue related to this change, so it doesn't help in reviewing. |
@Sr-Preet can you link to an issue describing what you're solving? |
@Sr-Preet I'm moving this pull request to draft for now. We'd love to understand what was the reasoning for this pull request and what problem does it solve before we do the review, as it seems that those details have been lost somewhere. Can you please link the issue you're trying to solve, or at least describe the problem? |
@Palid @novocaine @turt2live It Fixes element-hq/element-web#17859 |
Resolves the issue regarding the desktop notification for replies.
Signed-off-by: Sarpreet ssarpreet.786@gmail.com
Fixes element-hq/element-web#17859
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.