Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long names are displayed inconsistently in thread summary #21472

Closed
frakic opened this issue Mar 18, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#8149
Closed

Long names are displayed inconsistently in thread summary #21472

frakic opened this issue Mar 18, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#8149
Assignees
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs

Comments

@frakic
Copy link

frakic commented Mar 18, 2022

Steps to reproduce

  1. Where are you starting? What can you see?
    -I change my display name to something long
  2. What do you click?
    -I reply to a thread
  3. More steps…
    -I reply to another thread with longer text

Screenshot

Outcome

What did you expect?

I expected my name to be displayed consistently across all thread summaries.

What happened instead?

My display name is sometimes wrapped within the summary and sometimes only a part of my name is displayed.

Operating system

Windows 10 Home 21H1

Browser information

Firefox 98.0.1 (64-bit)

URL for webapp

https://develop.element.io

Application version

Element version: 071a541-react-cdcf6d0fd182-js-779afbcb3992 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No

@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 18, 2022
@HarHarLinks
Copy link

if you decide to use multiple ("up to 2") lines at all, then there should be less spacing between lines and instead more to the outside
image

@janogarcia
Copy link

@gsouquet @t3chguy Please refer to these notes for suggested behavior and implementation:

#21502 (comment)

@janogarcia
Copy link

@t3chguy After further testing, turns out the alternate approach I shared works best for variable length content.

.mx_ThreadInfo_sender {
    text-overflow: ellipsis;
    overflow: hidden;
    white-space: nowrap;
}

// Add this extra declaration

.mx_ThreadInfo_content {
    flex: 1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs
Projects
None yet
5 participants