New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply tweaks to Thread list as per design spec #8149
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #8149 +/- ##
===========================================
- Coverage 28.69% 28.68% -0.01%
===========================================
Files 851 851
Lines 49779 49788 +9
Branches 12658 12662 +4
===========================================
Hits 14282 14282
- Misses 35497 35506 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've unchecked and added notes to all tasks that need some attention:
element-hq/element-web#21502 (comment)
Update the truncating behavior for the thread summary:
element-hq/element-web#21472 (comment)
Hi, sorry if it's not the right place to ask, but figured it's the MR where this behavior was introduced. Gone through the linked issues, but not sure I understand the
Thanks! |
For element-hq/element-web#21502
Fixes element-hq/element-web#21538
Fixes element-hq/element-web#21472
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is plusX-Breaking-Change
if it's a breaking change.Preview: https://pr8149--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.