Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to clear unread message notifications #23754

Closed
jlfrance opened this issue Nov 11, 2022 · 16 comments · Fixed by matrix-org/matrix-js-sdk#2916
Closed

Unable to clear unread message notifications #23754

jlfrance opened this issue Nov 11, 2022 · 16 comments · Fixed by matrix-org/matrix-js-sdk#2916
Assignees
@germain-gg
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@jlfrance
Copy link

Steps to reproduce

  1. I have read all my unread messages except for 15 messages in a room (internal room ID: !uLXVepEhQBObRjarPD:thesis.co)
  2. I open the room
  3. I click on threads
  4. I see two threads with a red dot
  5. I click each thread, scroll through the messages, and the unread message notification count changes to 19

Outcome

What did you expect?

I expected when I clicked on the threads with the red dot, that the unread message notifications would change to zero

What happened instead?

When I clicked on the threads with the red dot, the unread message count increased

Operating system

macOS

Application version

Element version: 1.11.5 Olm version: 3.2.12

How did you install the app?

https://element.io/get-started#download

Homeserver

chat.thesis.co

Will you send logs?

Yes
@jlfrance
Copy link
Author

A similar issue just happened in room id# !DuyKtxtmoGxbTLZlRW:thesis.co
The room had zero unread message notifications. I clicked into the room, clicked on the threads, and the unread message count for the room changed to 17.

@germain-gg
Copy link
Contributor

Thanks for you reporting this issue.
It looks very similar to #23683 which has been fixed as part of matrix-org/matrix-js-sdk#2862.

You can test those changes early on develop.element.io or wait for the next release of Element Web.

@germain-gg germain-gg mentioned this issue Nov 15, 2022
Closed
@jlfrance
Copy link
Author

I tested the changes in develope.element.io and the issues with room id# !DuyKtxtmoGxbTLZlRW:thesis.co are resolved however the unread message notifications from room ID: !uLXVepEhQBObRjarPD:thesis.co are not resolved. Additionally, there are a large number of persistent unread notifications appearing in other rooms. Do you suggest I report those or what should my expectation be regarding those?

@TheCycoONE
Copy link

@jlfrance I'm not sure if this is your issue, but I started using threads and was seeing unread notifications in a room that wouldn't go away. There were also unread notifications in the thread view, but I couldn't see them. I eventually found there were expandable sections within the thread view that once all expanded made the notification count go away.

It was very hard to discover.

@jlfrance
Copy link
Author

Thanks @TheCycoONE, that was not the issue, I was aware of the "all threads" & "my threads" option. I am always able to locate the unread message, but the notification never clears despite reading each message.

@jlfrance
Copy link
Author

@gsouquet Thanks, I tested the changes in develope.element.io and the issues with room id# !DuyKtxtmoGxbTLZlRW:thesis.co are resolved however the unread message notifications from room ID: !uLXVepEhQBObRjarPD:thesis.co are not resolved. Additionally, there are a large number of persistent unread notifications appearing in other rooms. Do you suggest I report those or what should my expectation be regarding those?

@germain-gg germain-gg reopened this Nov 18, 2022
@germain-gg
Copy link
Contributor

germain-gg commented Nov 18, 2022 •
edited

@jlfrance reopening this issue as it seems there are problems that are unresolved with it.

Could you clarify the difference between this issue and #23770 ? They appear as duplicate to me, but there might be a subtle difference that I missed?

I would be interested in understanding a bit more the issue with persistent unread notifications? Under what circumstances do those appear (when starting Element up? when opening a thread?) ?

Are there ways to clear them up, does All Settings > Notifications > 'Clear notifications' have any impact?

And as a last resort, when you have tried all the other steps, does All Settings > Help & About > Clear cache & reload make a difference?

@jlfrance
Copy link
Author

jlfrance commented Nov 18, 2022 •
edited

@gsouquet Yes, you are correct, this is an identical issue to #23770. I was unable to locate 23770 and thought I had not actually submitted the issue so I submitted another issue. Sorry for that oversight.

The issue was the unread messages were persistent through the closing and reopening of Element - during the testing 3 days ago, I was able to successfully clear the messages in !DuyKtxtmoGxbTLZlRW:thesis.co however, the messages in !uLXVepEhQBObRjarPD:thesis.co persisted despite opening the indicated threads, closing the app and reopening, etc. Today, when I tested again, I no longer see unread messages in !uLXVepEhQBObRjarPD:thesis.co. However, during testing, I clicked on a room that did not have an unread notification in it which resulted in an unread notification popping up. Attempts to clear this were unsuccessful until I follow All Settings > Help & About > Clear cache & reload.

Additionally, All Settings > Notifications > 'Clear notifications' has not historically worked (screen recording attached).

To recap: after testing just now, the original notifications WERE cleared, and all other notifications were cleared through All Settings > Help & About > Clear cache & reload

Screen.Recording.2022-11-18.at.8.37.53.PM.mov

@jlfrance
Copy link
Author

jlfrance commented Nov 18, 2022 •
edited

My original video was too large to upload, so is recorded it again, but this time when I went to develop.element.io, my messages weren't all cleared as they had been when I performed All Settings > Help & About > Clear cache & reload which is why there is a discrepancy in what I described vs what you see in my video. Hopefully, it will be helpful anyway. If the information appears to have some discrepancies, it is because each time I go to test, the number and location of unread messages is different. This refers specifically to messages I know are old and I have read weeks or months ago suddenly appearing as an unread notification. I understand that new, actual unread messages will appear.

Video of messages not clearing !uLXVepEhQBObRjarPD:thesis.co

Screen.Recording.2022-11-18.at.9.00.09.PM.mov

@johanricher
Copy link

I can confirm I have this bug too.

Before closing the client, I have no unread messages. When I open it back, some rooms have unread messages (while there has been no actual new message). At the moment, I manage to remove the unread messages by clicking on threads at random to open/load their messages, until the unread counter disappears. This seem to happen with random rooms (I cannot figure the pattern or cause of this bug) and be solved by opening random threads within those rooms.

@germain-gg germain-gg self-assigned this Nov 29, 2022
@germain-gg germain-gg added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Labs labels Nov 29, 2022
@germain-gg germain-gg mentioned this issue Nov 29, 2022
Merged
3 tasks
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v22.0.0' into sc
789e2bf 
* Enable users to join group calls from multiple devices ([\matrix-org#2902](matrix-org#2902)).
* Deprecate a function containing a typo ([\matrix-org#2904](matrix-org#2904)).
* sliding sync: add receipts extension ([\matrix-org#2912](matrix-org#2912)).
* Define a spec support policy for the js-sdk ([\matrix-org#2882](matrix-org#2882)).
* Further improvements to e2ee logging ([\matrix-org#2900](matrix-org#2900)).
* sliding sync: add support for typing extension ([\matrix-org#2893](matrix-org#2893)).
* Improve logging on Olm session errors ([\matrix-org#2885](matrix-org#2885)).
* Improve logging of e2ee messages ([\matrix-org#2884](matrix-org#2884)).
* Fix 3pid invite acceptance not working due to mxid being sent in body ([\matrix-org#2907](matrix-org#2907)). Fixes element-hq/element-web#23823.
* Don't hang up calls that haven't started yet ([\matrix-org#2898](matrix-org#2898)).
* Read receipt accumulation for threads ([\matrix-org#2881](matrix-org#2881)).
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
@johanricher
Copy link

johanricher commented Dec 16, 2022 •
edited

Can you confirm that the fix to this issue is being used in the current version of element-web (1.11.16)? Because I'm still experiencing the issues I shared above.

Edit : it seems so. @gsouquet can you please re-open this issue so it can be investigated further?

su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v23.0.0' into sc
b9afe23 
* Process `m.room.encryption` events before emitting `RoomMember` events ([\matrix-org#2914](matrix-org#2914)). Fixes element-hq/element-web#23819.
* Don't expose `calls` on `GroupCall` ([\matrix-org#2941](matrix-org#2941)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Add a message ID on each to-device message ([\matrix-org#2938](matrix-org#2938)).
* Enable multiple users' power levels to be set at once ([\matrix-org#2892](matrix-org#2892)). Contributed by @GoodGuyMarco.
* Include pending events in thread summary and count again ([\matrix-org#2922](matrix-org#2922)). Fixes element-hq/element-web#23642.
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Add method to get outgoing room key requests for a given event ([\matrix-org#2930](matrix-org#2930)).
* Fix messages loaded during initial fetch ending up out of order ([\matrix-org#2971](matrix-org#2971)). Fixes element-hq/element-web#23972.
* Fix #23919: Root message for new thread loaded from network ([\matrix-org#2965](matrix-org#2965)). Fixes element-hq/element-web#23919.
* Fix #23916: Prevent edits of the last message in a thread getting lost ([\matrix-org#2951](matrix-org#2951)). Fixes element-hq/element-web#23916 and element-hq/element-web#23942.
* Fix infinite loop when restoring cached read receipts ([\matrix-org#2963](matrix-org#2963)). Fixes element-hq/element-web#23951.
* Don't swallow errors coming from the shareSession call ([\matrix-org#2962](matrix-org#2962)). Fixes element-hq/element-web#23792.
* Make sure that MegolmEncryption.setupPromise always resolves  ([\matrix-org#2960](matrix-org#2960)).
* Do not calculate highlight notifs for threads unknown to the room ([\matrix-org#2957](matrix-org#2957)).
* Cache read receipts for unknown threads ([\matrix-org#2953](matrix-org#2953)).
* bugfix: sliding sync initial room timelines shouldn't notify ([\matrix-org#2933](matrix-org#2933)).
* Redo key sharing after own device verification ([\matrix-org#2921](matrix-org#2921)). Fixes element-hq/element-web#23333.
* Move updated threads to the end of the thread list ([\matrix-org#2923](matrix-org#2923)). Fixes element-hq/element-web#23876.
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
@knoedel001
Copy link

I have this issue as well. Not using threads, but several normal direct messages and rooms have stuck notifications. I can clear them temporarily with All Settings > Help & About > Clear cache & reload, but they keep reappearing after the next restart of Element. Issue exists on Element Web and Element Desktop on different computers. The mobile clients for Android and iOS have no issues and also Fluffy Chat does not display any notifications left. The problem exists for longer time now and the notifications stuck are getting more and more. My Element Web and Desktop installation is on 1.11.26.

@aislinnORG
Copy link

We also still have this issue on our Desktop app on Mac laptops! Feels like whack-a-mole. The new "mark as read" function means you can clear the badges but then they just pop back up at random. I am currently on Version 1.11.34 (1.11.34).

@t3chguy
Copy link
Member

t3chguy commented Jun 22, 2023

@aislinnORG the desktop app is Element Web wrapped in Electron + Seshat + Keytar, so the same bug being present there is expected.

@t3chguy
Copy link
Member

t3chguy commented Jun 22, 2023

#24392 is the issue to track

@aislinnORG
Copy link

thank you that's helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix synthesizeReceipt matrix-org/matrix-js-sdk
7 participants
@germain-gg @TheCycoONE @t3chguy @johanricher @jlfrance @knoedel001 @aislinnORG