Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification for my own message in a thread that took forever to encrypt #25178

Closed
MadLittleMods opened this issue Apr 21, 2023 · 3 comments
Closed

Notification for my own message in a thread that took forever to encrypt #25178

MadLittleMods opened this issue Apr 21, 2023 · 3 comments
Labels
A-Notifications A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Apr 21, 2023 •
edited
Loading

Steps to reproduce

  1. Reply to a thread in an encrypted room
  2. Make an edit before the message sends
  3. Go to another room because it's taking forever to encrypt and will send eventually
  4. See a notification for the thread root

Outcome

What did you expect?

I sent the message so I don't care about new activity in the thread about it (no notification)

What happened instead?

I see a notification for the thread root indicating activity happened in that thread (#24620)

Operating system

Windows 10

Browser information

Chrome Version 112.0.5615.122

URL for webapp

develop.element.io

Application version

Element version: 66c86a6-react-2da52372d49c-js-743ba5f050ea Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes
@MadLittleMods MadLittleMods added T-Defect A-Notifications A-Threads S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 21, 2023
@t3chguy
Copy link
Member

t3chguy commented Apr 24, 2023

We don't use toasts for message notifications, do you mean HTML5 Desktop notifications? Toasts are the things we have top left, desktop notifications tend to be on the right but it depends on your OS/WM/NM

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 24, 2023
@MadLittleMods MadLittleMods changed the title Toast notification for my own message in a thread that took forever to encrypt Notification for my own message in a thread that took forever to encrypt Apr 24, 2023
@MadLittleMods
Copy link
Contributor Author

@t3chguy I've updated it to just say "notification" ⏩

I wasn't referring to some specific toast implementation in our app.

@t3chguy t3chguy removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 25, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 21, 2023

I believe this to be fixed now, please shout if you can reproduce on >1.11.36

@t3chguy t3chguy closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MadLittleMods @t3chguy