Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disasterous performance on FF on rooms with large encrypted images #2678

Closed
ara4n opened this issue Dec 1, 2016 · 9 comments · Fixed by matrix-org/matrix-react-sdk#1864
Closed

Comments

@ara4n
Copy link
Member

ara4n commented Dec 1, 2016

In a room with several encrypted 3MB images, silwol reports that FF completely grinds to a halt until you move to a different room, pausing for ~30s on end. Attached is a JS profile, and a screenshot of what it's doing. It seems to be spending multiple blocks of 10s in PresShell::DeReflow(), and then over 3s actually painting.

screen shot 2016-12-01 at 23 39 52

@ara4n
Copy link
Member Author

ara4n commented Dec 1, 2016

this happens both on /app and /develop.

@ara4n
Copy link
Member Author

ara4n commented Dec 2, 2016

i can reproduce this spectacularly with 3x 3MB images.

@ara4n
Copy link
Member Author

ara4n commented Jan 3, 2017

see also #2866

@florianjacob
Copy link

Can reproduce with 2x 4MB images.

@ara4n
Copy link
Member Author

ara4n commented Apr 30, 2018

should now be fixed at last by matrix-org/matrix-react-sdk#1864. feedback welcome!

@ara4n ara4n closed this as completed Apr 30, 2018
@nailyk-fr
Copy link

Thanks! Sorry for stupid question but looks like those patches are only in develop branch. While clicking at the version number and read the commit history, looks like my client is not using it.
How can I test the web-ui on develop branch please ?

@t3chguy
Copy link
Member

t3chguy commented May 1, 2018

@nailyk-fr try https://riot.im/develop

@nailyk-fr
Copy link

Many thanks.
No way to compare with earliest performance. Scrolling and writing are now working damn fast.

I sent a report through the webui some days ago about gif/videos playing making webUI unusable but looks like it fixed it too.

Will test more but it is now really good! Many thanks for the fix!

@nailyk-fr
Copy link

After more testing performance are just awesome. (not tried yet on my 10 years old laptop)
However am not able to tell if this patch or something else fixed it as I switched to /develop only yesterday.

Thanks for reactivity... And many thanks for the apps !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment