Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening MemberInfo starts a download of many users' keys #3310

Closed
richvdh opened this issue Feb 23, 2017 · 3 comments · Fixed by matrix-org/matrix-js-sdk#425
Closed

Opening MemberInfo starts a download of many users' keys #3310

richvdh opened this issue Feb 23, 2017 · 3 comments · Fixed by matrix-org/matrix-js-sdk#425
Labels
A-E2EE A-Performance A-User-Info P1 T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Feb 23, 2017

... which is slooow. Why are we downloading keys other than those for the user in question?
@richvdh
Copy link
Member Author

richvdh commented Feb 23, 2017

https://riot.im/bugreports/listing/2017-02-23/141949/

@lampholder lampholder mentioned this issue Apr 20, 2017
Closed
@ara4n
Copy link
Member

ara4n commented Apr 23, 2017

related to #3588

richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 25, 2017
@richvdh
Rework device list tracking logic
09860b5 
Yet another attempt at fixing
element-hq/element-web#2305.

This now implements the algorithm described at
http://matrix.org/speculator/spec/HEAD/client_server/unstable.html#tracking-the-device-list-for-a-user:

* We now keep a flag to tell us which users' device lists we are tracking. That
  makes it much easier to figure out whether we should care about device-update
  notifications from /sync (thereby fixing
  element-hq/element-web#3588).

* We use the same flag to indicate whether the device list for a particular
  user is out of date. Previously we did this implicitly by only updating the
  stored sync token when the list had been updated, but that was somewhat
  complicated, and in any case didn't help in cases where we initiated the key
  download due to a user joining an encrypted room.

Also fixes element-hq/element-web#3310.
@richvdh richvdh mentioned this issue Apr 25, 2017
Merged
richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 25, 2017
@richvdh
Rework device list tracking logic
ab19b9b 
Yet another attempt at fixing
element-hq/element-web#2305.

This now implements the algorithm described at
http://matrix.org/speculator/spec/HEAD/client_server/unstable.html#tracking-the-device-list-for-a-user:

* We now keep a flag to tell us which users' device lists we are tracking. That
  makes it much easier to figure out whether we should care about device-update
  notifications from /sync (thereby fixing
  element-hq/element-web#3588).

* We use the same flag to indicate whether the device list for a particular
  user is out of date. Previously we did this implicitly by only updating the
  stored sync token when the list had been updated, but that was somewhat
  complicated, and in any case didn't help in cases where we initiated the key
  download due to a user joining an encrypted room.

Also fixes element-hq/element-web#3310.
richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 25, 2017
@richvdh
Rework device list tracking logic (#425)
5020d4e 
Yet another attempt at fixing
element-hq/element-web#2305.

This now implements the algorithm described at
http://matrix.org/speculator/spec/HEAD/client_server/unstable.html#tracking-the-device-list-for-a-user:

* We now keep a flag to tell us which users' device lists we are tracking. That
  makes it much easier to figure out whether we should care about device-update
  notifications from /sync (thereby fixing
  element-hq/element-web#3588).

* We use the same flag to indicate whether the device list for a particular
  user is out of date. Previously we did this implicitly by only updating the
  stored sync token when the list had been updated, but that was somewhat
  complicated, and in any case didn't help in cases where we initiated the key
  download due to a user joining an encrypted room.

Also fixes element-hq/element-web#3310.
@richvdh
Copy link
Member Author

richvdh commented Apr 25, 2017

Fixed by matrix-org/matrix-js-sdk#425

@richvdh richvdh closed this as completed Apr 25, 2017
@ara4n ara4n mentioned this issue Apr 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Performance A-User-Info P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework device list tracking logic matrix-org/matrix-js-sdk
2 participants
@ara4n @richvdh