Rework device list tracking logic #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(should also indirectly help with element-hq/element-web#3660, since it will mean we are less likely to fill up the localstorage for device lists we don't care about) |
Yet another attempt at fixing element-hq/element-web#2305. This now implements the algorithm described at http://matrix.org/speculator/spec/HEAD/client_server/unstable.html#tracking-the-device-list-for-a-user: * We now keep a flag to tell us which users' device lists we are tracking. That makes it much easier to figure out whether we should care about device-update notifications from /sync (thereby fixing element-hq/element-web#3588). * We use the same flag to indicate whether the device list for a particular user is out of date. Previously we did this implicitly by only updating the stored sync token when the list had been updated, but that was somewhat complicated, and in any case didn't help in cases where we initiated the key download due to a user joining an encrypted room. Also fixes element-hq/element-web#3310.
richvdh
force-pushed
the
rav/device_list
branch
from
09860b5
to
ab19b9b
Compare
|
There's a lot of console.log being added. I assume it's there for debugging unknown session/key errors in the wild. |
NegativeMjark
approved these changes
Apr 25, 2017
well, I'm not sure it's a lot - most of them are just being moved around. But yeah, it's basically to try to debug uisis. |
This was referenced Apr 25, 2017
|
Now amended by #431. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another attempt at fixing element-hq/element-web#2305.
This now implements the algorithm described at http://matrix.org/speculator/spec/HEAD/client_server/unstable.html#tracking-the-device-list-for-a-user:
We now keep a flag to tell us which users' device lists we are tracking. That makes it much easier to figure out whether we should care about device-update notifications from /sync (thereby fixing Sending a message in a 1:1 E2E room triggers explosion of downloading device keys, which takes minutes element-hq/element-web#3588).
We use the same flag to indicate whether the device list for a particular user is out of date. Previously we did this implicitly by only updating the stored sync token when the list had been updated, but that was somewhat complicated, and in any case didn't help in cases where we initiated the key download due to a user joining an encrypted room.
Also fixes element-hq/element-web#3310.