Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release scripts don't update package-lock.json version #7083

Closed
dbkr opened this issue Jul 24, 2018 · 3 comments
Closed

Release scripts don't update package-lock.json version #7083

dbkr opened this issue Jul 24, 2018 · 3 comments
Labels
A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning

Comments

@dbkr
Copy link
Member

dbkr commented Jul 24, 2018

...so our release tags end up with a package.json with the right version and a package-lock.json with a mismatched version. I think this just makes npm disregard the package-lock.json file, making it entirely pointless.

It may be better to just remove the thing from version control until we figure out this and whatever other nuances it introduces.
@lampholder
Copy link
Member

It may be better to just remove the thing from version control until we figure out this and whatever other nuances it introduces.

Agreed - make it so.

@lampholder lampholder added the T-Task Tasks for the team like planning label Jul 27, 2018
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 31, 2018
@dbkr
Remove package-lock.json for now
f0d135d 
As per element-hq/element-web#7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.
@dbkr dbkr mentioned this issue Jul 31, 2018
Merged
dbkr added a commit that referenced this issue Jul 31, 2018
@dbkr
Remove package-lock.json for now
ccf52d3 
As per #7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.
@dbkr dbkr mentioned this issue Jul 31, 2018
Merged
@dbkr
Copy link
Member Author

dbkr commented Jul 31, 2018

It is done

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 1, 2018
@dbkr
Remove package-lock.json for now
8e27cda 
As per element-hq/element-web#7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.
@aaronraimist aaronraimist mentioned this issue Oct 27, 2018
Merged
@jryans
Copy link
Collaborator

jryans commented Mar 11, 2019

Through changes to our release scripts such as matrix-org/matrix-js-sdk@073a025 and matrix-org/matrix-js-sdk@68c8fe0, we now attempt to commit lock files generally.

At the moment, the React SDK still ignores the lock file, but I'll clean that up as part of the switch to Yarn in #7756.

@jryans jryans closed this as completed Mar 11, 2019
@jryans jryans added the A-Packaging Packaging, signing, releasing label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @dbkr @lampholder