Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIFs now autoplay even if you've disabled the setting to do so #9658

Closed
ara4n opened this issue May 9, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#2962
Closed

GIFs now autoplay even if you've disabled the setting to do so #9658

ara4n opened this issue May 9, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#2962
Assignees
@jryans
Labels
T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented May 9, 2019

regression.
@turt2live
Copy link
Member

I'm not able to reproduce this - was it a sticker by chance? (making it a duplicate of #6534)

@turt2live turt2live added T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter X-Regression labels May 9, 2019
@uhoreg
Copy link
Member

uhoreg commented May 9, 2019

I'm seeing this too, ever since I upgraded to 1.1.0. It happens with non-stickers.

@jryans
Copy link
Collaborator

jryans commented May 10, 2019

I am seeing this also, will investigate...

@jryans jryans self-assigned this May 10, 2019
@jryans jryans added this to In Progress in Web App Team via automation May 10, 2019
@turt2live
Copy link
Member

My testing was flawed I guess, as I can reproduce it now too. Possibly tested against an outdated version of Riot?

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 13, 2019
@jryans
Always thumbnail for GIFs
7881369 
When displaying a GIF, we always want to thumbnail so that we can properly
respect the user's GIF autoplay setting (which relies on thumbnailing to produce
the static preview image).

Fixes element-hq/element-web#9658
@jryans
Copy link
Collaborator

jryans commented May 13, 2019

The regression was caused by matrix-org/matrix-react-sdk#2439.

@jryans jryans removed the X-Needs-Info This issue is blocked awaiting information from the reporter label May 13, 2019
@jryans jryans mentioned this issue May 13, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team May 13, 2019
Web App Team automation moved this from In Review to In Test May 14, 2019
dbkr pushed a commit to matrix-org/matrix-react-sdk that referenced this issue May 15, 2019
@jryans @dbkr
Always thumbnail for GIFs
6ea590c 
When displaying a GIF, we always want to thumbnail so that we can properly
respect the user's GIF autoplay setting (which relies on thumbnailing to produce
the static preview image).

Fixes element-hq/element-web#9658
@jryans jryans moved this from In Test to Done in Web App Team May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always thumbnail for GIFs matrix-org/matrix-react-sdk
4 participants
@jryans @uhoreg @turt2live @ara4n