Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always thumbnail for GIFs #2962

Merged
merged 3 commits into from
May 14, 2019
Merged

Always thumbnail for GIFs #2962

merged 3 commits into from
May 14, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented May 13, 2019

When displaying a GIF, we always want to thumbnail so that we can properly
respect the user's GIF autoplay setting (which relies on thumbnailing to produce
the static preview image).

This regression was caused by #2439.

Fixes element-hq/element-web#9658

When displaying a GIF, we always want to thumbnail so that we can properly
respect the user's GIF autoplay setting (which relies on thumbnailing to produce
the static preview image).

Fixes element-hq/element-web#9658
@jryans jryans requested a review from a team May 13, 2019 17:32
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment wouldn't hurt for future problems in this area, as it doesn't make sense to me that we have an autoplay setting and still thumbnail.

@jryans
Copy link
Collaborator Author

jryans commented May 14, 2019

Comment added.

@jryans jryans merged commit 66aabdc into develop May 14, 2019
@dbkr dbkr mentioned this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GIFs now autoplay even if you've disabled the setting to do so
2 participants