Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You invited %1$@" still shows a matrix id #2866

Closed
Tracked by #2395
manuroe opened this issue May 17, 2024 · 1 comment · Fixed by #2883
Closed
Tracked by #2395

"You invited %1$@" still shows a matrix id #2866

manuroe opened this issue May 17, 2024 · 1 comment · Fixed by #2883
Assignees
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@manuroe
Copy link
Member

manuroe commented May 17, 2024

Steps to reproduce

This is a bug found by Hans while testing element-hq/element-meta#2395.

  1. Open DM you started
  2. Expand the room changes
  3. The app displays ""You invited @bob:matrix.org" instead of Bob
image

Outcome

What did you expect?

A display name instead of a matrix id like on EW:

image

The invite event has a displayname field:

{
  "content": {
    "displayname": "testiosr123",
    "is_direct": true,
    "membership": "invite"
  },
  "origin_server_ts": 1663321374100,
  "sender": "@Manu:matrix.org",
  "state_key": "@testiosr123:matrix.org",
  "type": "m.room.member",
  "unsigned": {
    "age": 52463967527
  },
  "event_id": "$ryCuR93bduTjs-u5CPZQPNPnZZK_AQtp2_4Ys2SUXxk",
  "room_id": "!hQMQdhNMYBzbNfRaKh:matrix.org"
}
@manuroe manuroe added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 17, 2024
@jmartinesp
Copy link
Contributor

Added matrix-org/matrix-rust-sdk#3428 as a first step to get the required display name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants