Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Use display names instead of matrix ids for state events #2722

Closed
24 of 41 tasks
Tracked by #2395
manuroe opened this issue Apr 17, 2024 · 2 comments · Fixed by #2739
Closed
24 of 41 tasks
Tracked by #2395

[Task] Use display names instead of matrix ids for state events #2722

manuroe opened this issue Apr 17, 2024 · 2 comments · Fixed by #2739
Assignees
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@manuroe
Copy link
Member

manuroe commented Apr 17, 2024

Please see and discuss the details in the meta issue.

The app must display user name for %1$@ in:

  • "state_event_avatar_url_changed" = "%1$@ changed their avatar";
  • "state_event_demoted_to_member" = "%1$@ was demoted to member"; Not used
  • "state_event_demoted_to_moderator" = "%1$@ was demoted to moderator"; Not used
  • "state_event_promoted_to_administrator" = "%1$@ was promoted to admin"; Not used
  • "state_event_promoted_to_moderator" = "%1$@ was promoted to moderator"; Not used
  • "state_event_room_avatar_changed" = "%1$@ changed the room avatar";
  • "state_event_room_avatar_removed" = "%1$@ removed the room avatar";
  • "state_event_room_created" = "%1$@ created the room";
  • "state_event_room_invite_accepted" = "%1$@ accepted the invite" We do not have the display name here, only the Id
  • "state_event_room_invite_by_you" = "You invited %1$@"; We do not have the display name here, only the Id
  • "state_event_room_invite_you" = "%1$@ invited you";
  • "state_event_room_join" = "%1$@ joined the room";
  • "state_event_room_knock" = "%1$@ requested to join";
  • "state_event_room_knock_accepted_by_you" = "%1$@ allowed you to join";
    The value was wrong, I changed it to You allowed %1$@ to join and we do not have the display name here, only the Id
  • "state_event_room_knock_denied_by_you" = "You rejected %1$@'s request to join"; We do not have the display name here, only the Id
  • "state_event_room_knock_denied_you" = "%1$@ rejected your request to join";
  • "state_event_room_knock_retracted" = "%1$@ is no longer interested in joining";
  • "state_event_room_leave" = "%1$@ left the room";
  • "state_event_room_name_changed" = "%1$@ changed the room name to: %2$@";
  • "state_event_room_name_removed" = "%1$@ removed the room name";
  • "state_event_room_none" = "%1$@ made no changes";
  • "state_event_room_reject" = "%1$@ rejected the invitation"; We do not have the display name here, only the Id
  • "state_event_room_topic_changed" = "%1$@ changed the topic to: %2$@";
  • "state_event_room_topic_removed" = "%1$@ removed the room topic";
  • "state_event_room_unknown_membership_change" = "%1$@ made an unknown change to their membership"; Not used
  • "state_event_room_third_party_invite_by_you" = "You sent an invitation to %1$@ to join the room"; We only have the displayName here, but it's an email (?)
  • "state_event_room_third_party_revoked_invite_by_you" = "You revoked the invitation for %1$@ to join the room"; We do not have the display name here, only the Id

%1$@ and %2$@ must be user names in:

  • "state_event_room_invite" = "%1$@ invited %2$@"; We do not have the display name for %2 here, only the Id
  • "state_event_room_knock_accepted" = "%1$@ allowed %2$@ to join"; We do not have the display name for %2 here, only the Id
  • "state_event_room_knock_denied" = "%1$@ rejected %2$@'s request to join"; We do not have the display name for %2 here, only the Id
  • "state_event_room_third_party_invite" = "%1$@ sent an invitation to %2$@ to join the room"; We only have the displayName for %2 here, but it's an email (?)
  • "state_event_room_third_party_revoked_invite" = "%1$@ revoked the invitation for %2$@ to join the room"; We only have the displayName for %2 here, but it's an email (?)

%1$@ must be a matrix id in:

  • "state_event_display_name_changed_from" = "%1$@ changed their display name from %2$@ to %3$@";
  • "state_event_display_name_removed" = "%1$@ removed their display name (it was %2$@)";
  • "state_event_display_name_set" = "%1$@ set their display name to %2$@";
  • "state_event_room_ban_by_you" = "You banned %1$@";
  • "state_event_room_remove_by_you" = "You removed %1$@";
  • "state_event_room_unban_by_you" = "You unbanned %1$@";

%1$@ must be a user name and %2$@ must be a matrix id in:

  • "state_event_room_ban" = "%1$@ banned %2$@";
  • "state_event_room_remove" = "%1$@ removed %2$@";
  • "state_event_room_unban" = "%1$@ unbanned %2$@";
@manuroe manuroe added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 17, 2024
@manuroe manuroe changed the title [Task] Use display names instead of matrix ids for membership changes in EX [Task] Use display names instead of matrix ids for membership changes Apr 17, 2024
@manuroe manuroe changed the title [Task] Use display names instead of matrix ids for membership changes [Task] Use display names instead of matrix ids for state events Apr 17, 2024
@bmarty bmarty self-assigned this Apr 22, 2024
bmarty added a commit that referenced this issue Apr 22, 2024
- Rename some parameter and val from `senderDisplayName` (and consort) to `senderDisambiguatedDisplayName`.
- In `InReplyToDetails`, replace `senderDisplayName` and `senderAvatarUrl` by `senderProfile`.
bmarty added a commit that referenced this issue Apr 22, 2024
- Rename some parameter and val from `senderDisplayName` (and consort) to `senderDisambiguatedDisplayName`.
- In `InReplyToDetails`, replace `senderDisplayName` and `senderAvatarUrl` by `senderProfile`.
bmarty added a commit that referenced this issue Apr 22, 2024
- Rename some parameter and val from `senderDisplayName` (and consort) to `senderDisambiguatedDisplayName`.
- In `InReplyToDetails`, replace `senderDisplayName` and `senderAvatarUrl` by `senderProfile`.
@manuroe
Copy link
Member Author

manuroe commented Jun 7, 2024

"state_event_room_invite_accepted" = "%1$@ accepted the invite" We do not have the display name here, only the Id
"state_event_room_invite_by_you" = "You invited %1$@"; We do not have the display name here, only the Id
"state_event_room_invite" = "%1$@ invited %2$@"; We do not have the display name for %2 here, only the Id

@bmarty, I tested the feature on EXA. Those strings are rendered in the app with the user displayname as expected. So, I do not understand your comments in the OP. EXA is fine on them but not EXI. EXI displays them as you described.

"state_event_room_leave" = "%1$@ left the room";

This one displays the user id on both EXA and EXI. EW is fine. The info seems to be in the matrix event.

@manuroe
Copy link
Member Author

manuroe commented Jun 7, 2024

The 3 first items in my comment got probably fixed with #2866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
2 participants