-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Use display names instead of matrix ids for state events #2722
Comments
- Rename some parameter and val from `senderDisplayName` (and consort) to `senderDisambiguatedDisplayName`. - In `InReplyToDetails`, replace `senderDisplayName` and `senderAvatarUrl` by `senderProfile`.
- Rename some parameter and val from `senderDisplayName` (and consort) to `senderDisambiguatedDisplayName`. - In `InReplyToDetails`, replace `senderDisplayName` and `senderAvatarUrl` by `senderProfile`.
- Rename some parameter and val from `senderDisplayName` (and consort) to `senderDisambiguatedDisplayName`. - In `InReplyToDetails`, replace `senderDisplayName` and `senderAvatarUrl` by `senderProfile`.
@bmarty, I tested the feature on EXA. Those strings are rendered in the app with the user displayname as expected. So, I do not understand your comments in the OP. EXA is fine on them but not EXI. EXI displays them as you described.
This one displays the user id on both EXA and EXI. EW is fine. The info seems to be in the matrix event. |
The 3 first items in my comment got probably fixed with #2866. |
Please see and discuss the details in the meta issue.
The app must display user name for
%1$@
in:The value was wrong, I changed it to
You allowed %1$@ to join
and we do not have the display name here, only the Id%1$@
and%2$@
must be user names in:%1$@
must be a matrix id in:%1$@
must be a user name and%2$@
must be a matrix id in:The text was updated successfully, but these errors were encountered: