Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.squareup.retrofit2:retrofit to v2.10.0 #2567

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 19, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.squareup.retrofit2:retrofit 2.9.0 -> 2.10.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

square/retrofit (com.squareup.retrofit2:retrofit)

v2.10.0

Compare Source

New

  • Support using Unit as a response type. This can be used for non-body HTTP methods like HEAD or body-containing HTTP methods like GET where the body will be discarded without deserialization.

  • kotlinx.serialization converter!

    This was imported from github.com/JakeWharton/retrofit2-kotlinx-serialization-converter/ and remains unchanged from its 1.0.0 release.

    The Maven coordinates are com.squareup.retrofit2:converter-kotlinx-serialization.

  • JAXB 3 converter!

    The Maven coordinates are com.squareup.retrofit2:converter-jaxb3.

  • @Header, @Headers, and @HeaderMap can now set non-ASCII values through the allowUnsafeNonAsciiValues annotation property. These are not technically compliant with the HTTP specification, but are often supported or required by services.

  • Publish a BOM of all modules. The Maven coordinates are com.squareup.retrofit2:retrofit-bom.

  • Invocation now exposes the service Class<?> and the instance on which the method was invoked. This disambiguates the source when service inheritence is used.

  • A response type keeper annotation processor is now available for generating shrinker rules for all referenced types in your service interface. In some cases, it's impossible for static shrinker rules to keep the entirety of what Retrofit needs at runtime. This annotation processor generates those additional rules. For more info see its README.

Changed

  • Add shrinker rules to retain the generic signatures of built-in types (Call, Response, etc.) which are used via reflection at runtime.
  • Remove backpressure support from RxJava 2 and 3 adapters. Since we only deliver a single value and the Reactive Streams specification states that callers must request a non-zero subscription value, we never need to honor backpressure.
  • Kotlin Retrofit.create function now has a non-null lower bound. Even if you specified a nullable type before this function would never return null.
  • Suspend functions now capture and defer all Throwable subtypes (not just Exception subtypes) to avoid Java's UndeclaredThrowableException when thrown synchronously.
  • Eagerly reject suspend fun functions that return Call<Body>. These are never correct, and should declare a return type of Body directly.
  • Support for Java 14-specific and Java 16-specific reflection needed to invoke default methods on interfaces have been moved to separate versions of a class through a multi-release jar. This should have no observable impact other than the jar now contains classes which target Java 14 and Java 16 bytecode that might trip up some static analysis tools which are not aware of multi-release jars.
  • Parameter names are now displayed in exception messages when available in the underlying Java bytecode.
  • Jackson converter now supports binary formats by using byte streams rather than character streams in its implementation. Use the create(ObjectMapper, MediaType) overload to supply the value of the Content-Type header for your format.

Fixed

  • Do not include synthetic methods when doing eager validation.
  • Use per-method rather than per-class locking when parsing annotations. This eliminates contention when multiple calls are made in quick succession at the beginning of the process lifetime.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 19, 2024 11:52
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 19, 2024
@renovate renovate bot requested review from ganfra and removed request for a team March 19, 2024 11:52
@ElementBot
Copy link
Collaborator

ElementBot commented Mar 19, 2024

Warnings
⚠️

gradle/libs.versions.toml#L6 - A newer version of com.android.tools.build:gradle than 8.2.2 is available: 8.3.1

⚠️

gradle/libs.versions.toml#L7 - A newer version of org.jetbrains.kotlin.plugin.serialization than 1.9.22 is available: 1.9.23

⚠️

gradle/libs.versions.toml#L8 - A newer version of com.google.devtools.ksp than 1.9.22-1.0.17 is available: 1.9.23-1.0.19

⚠️

gradle/libs.versions.toml#L21 - A newer version of androidx.compose:compose-bom than 2024.02.02 is available: 2024.03.00

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.compose.compiler:compiler than 1.5.10 is available: 1.5.11

⚠️

gradle/libs.versions.toml#L41 - A newer version of io.element.android:wysiwyg-compose than 2.33.0 is available: 2.34.0

⚠️

gradle/libs.versions.toml#L66 - A newer version of com.google.firebase:firebase-bom than 32.7.4 is available: 32.8.0

⚠️

gradle/libs.versions.toml#L157 - A newer version of org.matrix.rustcomponents:sdk-android than 0.2.9 is available: 0.2.11

⚠️

gradle/libs.versions.toml#L167 - A newer version of com.vanniktech:blurhash than 0.2.0 is available: 0.3.0

⚠️

gradle/libs.versions.toml#L217 - A newer version of io.gitlab.arturbosch.detekt than 1.23.5 is available: 1.23.6

Generated by 🚫 dangerJS against a5d0b47

Copy link
Contributor

github-actions bot commented Mar 19, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/quxx8W

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.14%. Comparing base (5cc5a0b) to head (a5d0b47).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2567   +/-   ##
========================================
  Coverage    73.14%   73.14%           
========================================
  Files         1408     1408           
  Lines        34095    34095           
  Branches      6617     6617           
========================================
  Hits         24939    24939           
  Misses        5699     5699           
  Partials      3457     3457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member

bmarty commented Mar 19, 2024

We may want to change the coordinates of kotlinx-serialization to com.squareup.retrofit2:converter-kotlinx-serialization and use the new bom?

@ganfra
Copy link
Contributor

ganfra commented Mar 21, 2024

We may want to change the coordinates of kotlinx-serialization to com.squareup.retrofit2:converter-kotlinx-serialization and use the new bom?

Yes, do u take the point?

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 25, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 25, 2024
Copy link
Contributor Author

renovate bot commented Mar 25, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmarty!

@ganfra ganfra merged commit d3f2190 into develop Mar 25, 2024
19 checks passed
@ganfra ganfra deleted the renovate/com.squareup.retrofit2-retrofit-2.x branch March 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants