Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.maplibre.gl:android-sdk to v11 #2838

Merged
merged 6 commits into from
May 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 13, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.maplibre.gl:android-sdk 10.3.1 -> 11.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 13, 2024 14:53
@renovate renovate bot added the dependencies Pull requests that update a dependency file label May 13, 2024
@renovate renovate bot requested review from ganfra and removed request for a team May 13, 2024 14:53
@ElementBot
Copy link
Collaborator

ElementBot commented May 13, 2024

Warnings
⚠️

gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1

⚠️

gradle/libs.versions.toml#L21 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0 is available: 2.8.1

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

⚠️

gradle/libs.versions.toml#L206 - A newer version of androidx.appcompat:appcompat than 1.6.1 is available: 1.7.0

⚠️

libraries/maplibre-compose/src/main/kotlin/io/element/android/libraries/maplibre/compose/MapLibreMap.kt#L186 - Use AppCompatResources.getDrawable()

Generated by 🚫 dangerJS against 1414a48

@ganfra
Copy link
Contributor

ganfra commented May 14, 2024

Blocked by maplibre/maplibre-plugins-android#49

Copy link
Contributor Author

renovate bot commented May 21, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

github-actions bot commented May 21, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/KFHnt3

@spaetz
Copy link

spaetz commented May 23, 2024

The mentioned blocker at maplibre/maplibre-plugins-android#49 seems to have been fixed 3 days ago and a release was made including the fix.

@ganfra
Copy link
Contributor

ganfra commented May 27, 2024

The mentioned blocker at maplibre/maplibre-plugins-android#49 seems to have been fixed 3 days ago and a release was made including the fix.

I know, I've made the relevant changes over [there](https://github.com/element-hq/element-x-android/pull/2838/commits/a41d323c938ac3c23c679290abce62a3934f5892)

I need to fix tests and should be ok.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.42%. Comparing base (02d7c49) to head (1414a48).

Files Patch % Lines
.../android/libraries/maplibre/compose/MapLibreMap.kt 0.00% 2 Missing ⚠️
.../libraries/maplibre/compose/CameraPositionState.kt 50.00% 1 Missing ⚠️
...t/android/libraries/maplibre/compose/MapApplier.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2838   +/-   ##
========================================
  Coverage    75.42%   75.42%           
========================================
  Files         1546     1546           
  Lines        36838    36838           
  Branches      7142     7142           
========================================
  Hits         27785    27785           
  Misses        5319     5319           
  Partials      3734     3734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 30, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 30, 2024
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ganfra ganfra merged commit 324ff4f into develop May 30, 2024
22 of 24 checks passed
@ganfra ganfra deleted the renovate/org.maplibre.gl-android-sdk-11.x branch May 30, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants