Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give locale and theme to Element Call #3118

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 1, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Use Element Call with correct theme and language.

Motivation and context

Improve user experience and closes #3079

Screenshots / GIFs

image

Tests

  • Change system theme to dark
  • Change system language to not English (for instance French)
  • Start a call and observe that Element Call is rendered in dark mode and with the selected language (is supported)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner July 1, 2024 13:58
@bmarty bmarty requested review from ganfra and removed request for a team July 1, 2024 13:58
@bmarty bmarty added the PR-Change For updates to an existing feature label Jul 1, 2024
@@ -68,6 +70,7 @@ class CallScreenPresenter @AssistedInject constructor(
private val screenTracker: ScreenTracker,
private val appCoroutineScope: CoroutineScope,
private val activeCallManager: ActiveCallManager,
private val languageTagProvider: LanguageTagProvider,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce a LanguageTagProvider because unit test does not like using LocalConfiguration

Copy link
Contributor

github-actions bot commented Jul 1, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pawVCu

Copy link

sonarcloud bot commented Jul 1, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 1, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (32b1b6e) to head (4df18ea).

Files Patch % Lines
...droid/features/call/impl/ui/LanguageTagProvider.kt 0.00% 3 Missing ⚠️
...droid/features/call/impl/ui/CallScreenPresenter.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3118   +/-   ##
========================================
  Coverage    75.95%   75.95%           
========================================
  Files         1636     1637    +1     
  Lines        38613    38622    +9     
  Branches      7463     7465    +2     
========================================
+ Hits         29328    29335    +7     
- Misses        5396     5397    +1     
- Partials      3889     3890    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element Call: provide theme and language to the Widget
2 participants