vector-im/element-x-ios/issues/134 - Prevent home screen room last me… #138

stefanceriu · 2022-07-20T13:01:20Z

…ssage attributed string from being computed on every update

… from being computed on every update

github-actions · 2022-07-20T13:02:29Z

	Warnings
⚠️	Please add a changelog.
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️	UnitTests/Sources/AttributedStringBuilderTests.swift#L380 - `where` clauses are preferred over a single `if` inside a `for`. (`for_where`)

Generated by 🚫 Danger Swift against 96d592e

github-actions · 2022-07-20T13:32:51Z

Changes in 138 (2022-07-21)

✨ Features

Implement rageshake service. (#23)
Add filtering for rooms by name. (#26)
Settings screen minimal implementation. (#37)
DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
Room timeline: Add plain styler and add timeline option in settings screen. (#92)
Implement and use background tasks. (#99)

🙌 Improvements

Implement new ClientBuilder pattern for login (#120)
Flatten the room list by removing the encrypted groups. (#121)
Add AuthenticationService and missing UI tests on the flow. (#126)
Room: Use bubbles in the timeline. (#34)
Room: Add header view containing room avatar and encryption badge. (#35)
Add the splash, login and server selection screens from Element iOS along with a UserSessionStore. (#40)
DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
Bug report: Add GH labels. (#77)
Danger: Add a check for png files and warn to use SVG and PDF files. (#87)
Add localizations to UI tests target and add some checks. (#101)

🐛 Bugfixes

ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

Add swiftformat to the project and run it for the first time. (#129)
Use v0.0.1 of the DesignTokens package. (#78)
Update to v0.0.2 of the DesignTokens package. (#90)
Fix Danger's changelog detection. (#74)

Others

Add Screen as a suffix to all screens and tidy up the template. (#125)
Fix project urls in Towncrier configuration. (#96)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/8SJZUm

…and adopt them throughout the app

codecov-commenter · 2022-07-21T07:00:00Z

Codecov Report

Merging #138 (f2fe4ad) into develop (6081a8f) will decrease coverage by 0.04%.
The diff coverage is 12.82%.

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    35.54%   35.50%   -0.05%     
===========================================
  Files          166      166              
  Lines        11478    11520      +42     
  Branches      5633     5656      +23     
===========================================
+ Hits          4080     4090      +10     
- Misses        7307     7339      +32     
  Partials        91       91

Impacted Files	Coverage Δ
.../Sources/Screens/HomeScreen/HomeScreenModels.swift	`9.09% <ø> (ø)`
...urces/Screens/HomeScreen/HomeScreenViewModel.swift	`12.59% <0.00%> (-2.50%)`	⬇️
ElementX/Sources/Services/Room/RoomProxy.swift	`0.00% <ø> (ø)`
...ources/Services/Room/RoomSummary/RoomSummary.swift	`0.00% <0.00%> (ø)`
...ces/Services/Timeline/RoomTimelineController.swift	`0.00% <0.00%> (ø)`
...meline/TimelineItems/RoomTimelineItemFactory.swift	`0.00% <0.00%> (ø)`
...es/Other/HTMLParsing/AttributedStringBuilder.swift	`90.14% <100.00%> (+0.48%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6081a8f...f2fe4ad. Read the comment docs.