Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plain Timeline View #92

Closed
ismailgulek opened this issue Jun 23, 2022 · 0 comments · Fixed by #94
Closed

Plain Timeline View #92

ismailgulek opened this issue Jun 23, 2022 · 0 comments · Fixed by #94
Assignees
@ismailgulek
Labels
Z-BBQ-Alpha Required for ElementX - BBQ - Alpha

Comments

@ismailgulek
Copy link
Contributor

Recently implemented a bubbled timeline styler. Add one more styler to use the plain one, like in Element.
@ismailgulek ismailgulek self-assigned this Jun 23, 2022
@ismailgulek ismailgulek added the Z-BBQ-Alpha Required for ElementX - BBQ - Alpha label Jun 24, 2022
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Create TimelineStyle and store it in user defaults
54da095
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Create TimelineStyler observable environment object
c452cf6
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Use timeline list row insets from the styler
b4d1371
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 remove sender view, move header into the styler views
4e490df
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Add timeline style option in settings
4c3cc3e
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Add changelog
b6bc8d2
@ismailgulek ismailgulek mentioned this issue Jun 24, 2022
Merged
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 refactor some code duplications
d065cb3
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Fix TimelineStyletargets
dc7a207
ismailgulek added a commit that referenced this issue Jun 24, 2022
@ismailgulek
#92 Fix TimelineStyle targets
d7a7e02
ismailgulek added a commit that referenced this issue Jun 26, 2022
@ismailgulek
#92 Fix PR remarks
3357911
ismailgulek added a commit that referenced this issue Jun 26, 2022
@ismailgulek
#92 Fix inline PR comments
7704c31
ismailgulek added a commit that referenced this issue Jun 26, 2022
@ismailgulek
#92 Fix UI tests
30ce941
ismailgulek added a commit that referenced this issue Jun 27, 2022
@ismailgulek
#92 Rename bubbled to bubbles
11a3d0b
ismailgulek added a commit that referenced this issue Jun 27, 2022
@ismailgulek
Plain timeline styler (#94)
36c3450 
* #92 Create `TimelineStyle` and store it in user defaults

* #92 Create `TimelineStyler` observable environment object

* #92 Use timeline list row insets from the styler

* #92 remove sender view, move header into the styler views

* #92 Add timeline style option in settings

* #92 Add changelog

* #92 refactor some code duplications

* #92 Fix `TimelineStyle`targets

* #92 Fix `TimelineStyle` targets

* #92 Fix PR remarks

* #92 Fix inline PR comments

* #92 Fix UI tests

* #92 Rename bubbled to bubbles
This was referenced Jun 27, 2022
Merged
Merged
Merged
@stefanceriu stefanceriu mentioned this issue Jun 29, 2022
Closed
This was referenced Jun 29, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 4, 2022
Merged
Merged
This was referenced Jul 18, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
Z-BBQ-Alpha Required for ElementX - BBQ - Alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plain timeline styler element-hq/element-x-ios
1 participant
@ismailgulek