SwiftLint fixes. #2899
Merged
SwiftLint fixes. #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non_optional_string_data_conversion and static_over_final_class
This reverts part of 8a58691.
Generated by 🚫 Danger Swift against 3422dda |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2899 +/- ##
===========================================
- Coverage 78.16% 78.04% -0.12%
===========================================
Files 687 687
Lines 53363 53358 -5
===========================================
- Hits 41710 41644 -66
- Misses 11653 11714 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings from
non_optional_string_data_conversionandstatic_over_final_classrules.Note: This leaves the Data -> String warnings as that part of the rule is going to be reverted.