-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse Data -> String conversion rule #5601
Reverse Data -> String conversion rule #5601
Conversation
8f22541
to
6bca4f2
Compare
6bca4f2
to
f0d657d
Compare
Source/SwiftLintBuiltInRules/Rules/Lint/OptionalDataStringConversionRule.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some nits on formulation and style, this looks good and reasonable to me. Thank you for taking immediate (re)action on the comments in the original PR!
Source/SwiftLintBuiltInRules/Rules/Lint/NonOptionalStringDataConversionRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/NonOptionalStringDataConversionRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/OptionalDataStringConversionRule.swift
Outdated
Show resolved
Hide resolved
Please run |
1e6876f
to
d449a91
Compare
Really sorry @SimplyDanny, I can’t figure out how to fix the tests. The IntegrationTests seem to pass but I may be running them wrong somehow. I’ve addressed your other comments I think. |
You need to update |
The remaining fail is a deprecation that has just become active. I'll remove the obsolete rule later and rebase your PR. |
Thanks @SimplyDanny! Sorry for the massive delay on fixing up this PR. |
2686984
to
fa5bbb0
Compare
…ersionRule.swift Co-authored-by: Ben P. <benj.c.palmer@gmail.com>
3504f4a
to
f8a1efb
Compare
Please roll out an update. |
This is firing on collections that aren't Data (specifically EDIT: Looking at the implementation of |
With #5794, the rule now suggests |
This reverses the Data -> String portion of this PR by introducing a new rule, following feedback on the original issue. It leaves the String -> Data portion of the original rule unchanged.