Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

invites don't tell you what room you are being invited to #2555

Closed
ara4n opened this issue Aug 28, 2018 · 1 comment
Closed

invites don't tell you what room you are being invited to #2555

ara4n opened this issue Aug 28, 2018 · 1 comment
Assignees
@bmarty
Labels
bug
Milestone
Sprint 15

Comments

@ara4n
Copy link
Member

ara4n commented Aug 28, 2018

Either this has never worked, or it regressed when we switched from v1 to v2 API (plus the spec was wrong until today). We should be inspecting event.unsigned.invite_room_state for info about invites rather than event.invite_room_state as per matrix-org/matrix-spec-proposals#1568 (and element-hq/element-ios#2010 and element-hq/element-web#7229)
@bmarty bmarty added this to the Sprint 15 milestone Aug 28, 2018
@bmarty bmarty added the bug label Aug 28, 2018
@bmarty bmarty self-assigned this Oct 9, 2018
@bmarty
Copy link
Member

bmarty commented Oct 10, 2018

Currently nor Riot neither the Android SDK uses what is in "invite_room_state" data.
It seems that it can be useful when dealing with an invite for a Room from another HS.
I will ensure "invite_room_state" is parsed correctly in the SDK for now

bmarty added a commit to matrix-org/matrix-android-sdk that referenced this issue Nov 5, 2018
@bmarty
Move invite_room_state to the UnsignedData object (element-hq/riot-…
1b4411f 
…android#2555)
@bmarty bmarty mentioned this issue Nov 5, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bmarty bmarty

Labels
bug
Projects
None yet
Milestone
Sprint 15
Development

No branches or pull requests
2 participants
@ara4n @bmarty