Move invite_room_state to the correct place in the client-server API
#1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum. It's worth noting that the various SDKs expect it to not be in the unsigned block, and the spec was once correct: This presumably explains why all the Riots no longer give you nice details when you're invited to a room. Looks like v1 had these on the raw event, and v2 moved them to unsigned. But nobody remembered to update the spec or the clients :| |
This was referenced Aug 28, 2018
August 2018 r0
automation
moved this from In review (just the PRs)
to Reviewer approved
Aug 28, 2018
ara4n
approved these changes
Aug 28, 2018
August 2018 r0
automation
moved this from Reviewer approved
to Done (this list will be incomplete)
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' status check
Fixes #1350