Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] [select] el-select的disabled属性切换时，如果自定义了line-height，里面input框的高度计算有问题 #10840

Closed
u373693041 opened this issue Dec 1, 2022 · 0 comments · Fixed by #10847
Closed

[Component] [select] el-select的disabled属性切换时，如果自定义了line-height，里面input框的高度计算有问题 #10840

u373693041 opened this issue Dec 1, 2022 · 0 comments · Fixed by #10847
Labels
Community::Bug Report Component::Select inactive

Comments

@u373693041
Copy link

Bug Type: Component

Environment

  • Vue Version: 3.2.37
  • Element Plus Version: 2.2.25
  • Browser / OS: edge 104.0.1293.70
  • Build Tool: Vite

Reproduction

Related Component

  • el-select

Reproduction Link

Element Plus Playground

Steps to reproduce

1.将el-input的css变量--el-input-height置为42px;
2.改变el-select的disabled属性
3.会发现input的高度被强制设为了30px，但是我line-height设置为42px，所以应该计算为40px
image
yWDevc9gQF
image

What is Expected?

input高度计算为40px，或者不设置height属性

What is actually happening?

input高度计算为30px，导致变矮

Additional comments

(empty)
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Dec 1, 2022
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
e6593ca
@MrWeilian MrWeilian mentioned this issue Dec 1, 2022
Merged
3 tasks
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Dec 1, 2022
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
705e7e4
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Dec 1, 2022
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
92f50ae 
fix(components): [select] support custom height (element-plus#10840)
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Feb 11, 2023
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
cd7a5a2
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Feb 11, 2023
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
91e9f80 
fix(components): [select] support custom height (element-plus#10840)
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Feb 11, 2023
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
d121346
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Feb 27, 2023
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
0b19237 
fix(components): [select] support custom height (element-plus#10840)
MrWeilian added a commit to MrWeilian/element-plus that referenced this issue Feb 27, 2023
@MrWeilian
fix(components): [select] support custom height (element-plus#10840)
99efbd4
chenxch pushed a commit that referenced this issue Feb 27, 2023
@MrWeilian
fix(components): [select] support custom height (#10840) (#10847)
2f5629a 
* fix(components): [select] support custom height (#10840)

fix(components): [select] support custom height (#10840)

* fix(components): [select] support custom height (#10840)
@element-bot element-bot mentioned this issue Mar 3, 2023
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this issue Mar 26, 2023
@MrWeilian @loosheng
fix(components): [select] support custom height (element-plus#10840) (e…
091094a 
…lement-plus#10847)

* fix(components): [select] support custom height (element-plus#10840)

fix(components): [select] support custom height (element-plus#10840)

* fix(components): [select] support custom height (element-plus#10840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Community::Bug Report Component::Select inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(components): [select] support custom height (#10840) MrWeilian/element-plus
2 participants
@emojiiii @u373693041