fix(components): [select] support custom height (#10840) #10847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @MrWeilian, thank you for contributing element-plus.
|
|
|
|
Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=10847 |
MrWeilian
force-pushed
the
fix/select-style-height
branch
from
705e7e4
to
92f50ae
Compare
|
Could this change be reviewed as soon as possible please? This bug has a great impact on me, thank you |
|
demo |
|
#11374 |
chenxch
reviewed
Feb 11, 2023
MrWeilian
force-pushed
the
fix/select-style-height
branch
from
cd7a5a2
to
d121346
Compare
猴 我更新下分支 |
HeftyKoo
approved these changes
Feb 17, 2023
fix(components): [select] support custom height (element-plus#10840)
MrWeilian
force-pushed
the
fix/select-style-height
branch
from
d121346
to
99efbd4
Compare
|
😂 大佬们 这个pr能合并吗 又解决一次冲突啦🙈 |
loosheng
pushed a commit
to loosheng/element-plus
that referenced
this pull request
Mar 26, 2023
…lement-plus#10847) * fix(components): [select] support custom height (element-plus#10840) fix(components): [select] support custom height (element-plus#10840) * fix(components): [select] support custom height (element-plus#10840)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: [Component] [select] el-select的disabled属性切换时，如果自定义了line-height，里面input框的高度计算有问题
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.