Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(components): [autocomplete] #10405

Merged
merged 2 commits into from
Nov 4, 2022
Merged

docs(components): [autocomplete] #10405

merged 2 commits into from
Nov 4, 2022

Conversation

jw-foss
Copy link
Member

@jw-foss jw-foss commented Nov 4, 2022

  • Add new API component ref-type.
  • Update doc API name font-family.
  • Update API popup style.
  • Update Autocomplete documentations.

Screenshot

CleanShot 2022-11-04 at 15 05 42@2x

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@jw-foss
docs(components): [autocomplete]
7a82462 
* Add new API component `ref-type`.
* Update doc API name font-family.
* Update API popup style.
* Update Autocomplete documentations.
@jw-foss jw-foss requested a review from a team November 4, 2022 07:12
@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=10405
Please comment the example via this playground if needed.

chenxch
chenxch approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@jw-foss
I have two reference suggestions:

  1. In the dark mode, the color of the prompt text seems to be brighter.
  2. Enumeration type, I was wondering if it would be better to show the primitive type.

@jw-foss
Copy link
Member Author

jw-foss commented Nov 4, 2022

  1. Enumeration type, I was wondering if it would be better to show the primitive type.

Not so sure about what the primitive type means here. I think enum type for those enumerable values which are the perfect use case here.

@chenxch chenxch merged commit 71e6365 into dev Nov 4, 2022
@chenxch chenxch deleted the docs/autocomplete-documentation-updates branch November 4, 2022 08:19
@chenxch
Copy link
Member

chenxch commented Nov 4, 2022

  1. Enumeration type, I was wondering if it would be better to show the primitive type.

Not so sure about what the primitive type means here. I think enum type for those enumerable values which are the perfect use case here.

All right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

Assignees

@jw-foss jw-foss

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jw-foss @chenxch