Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select] fix the hoverIndex display error #11297

Merged
merged 2 commits into from
Feb 25, 2023
Merged

fix(components): [select] fix the hoverIndex display error #11297

merged 2 commits into from
Feb 25, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Jan 18, 2023 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix #11294 fix #11280

@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 18, 2023
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=11297
Please comment the example via this playground if needed.

@btea btea marked this pull request as draft January 18, 2023 02:57
@btea btea marked this pull request as ready for review January 19, 2023 09:27
ryuhangyeong
ryuhangyeong approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@btea btea requested review from jw-foss and tolking February 17, 2023 01:12
@tolking tolking linked an issue Feb 22, 2023 that may be closed by this pull request
[Component] [select] After modifying options by using custom search, using up and down keys on the keyboard will cause confusion #11678
Closed
@btea btea merged commit 842fb2b into dev Feb 25, 2023
@btea btea deleted the fix/select-arrow-event branch February 25, 2023 08:43
@element-bot element-bot mentioned this pull request Mar 3, 2023
Merged
3 tasks
@acyza acyza mentioned this pull request Mar 10, 2023
Closed
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@btea @loosheng
fix(components): [select] fix the hoverIndex display error (element-p…
f42ddc2 
…lus#11297)

* fix(components): [select] fix the hoverIndex display error

* fix: update useSelect
@btea btea mentioned this pull request Jul 11, 2023
Merged
3 tasks
wzc520pyfm added a commit to wzc520pyfm/element-plus that referenced this pull request Jul 30, 2023
@wzc520pyfm
fix(components): [select] compatible element-plus#11297
5e2d24b
wzc520pyfm added a commit to wzc520pyfm/element-plus that referenced this pull request Aug 20, 2023
@wzc520pyfm
fix(components): [select] compatible element-plus#11297
66ee3eb
tolking pushed a commit that referenced this pull request Aug 31, 2023
@wzc520pyfm
fix(components): [select] fix hover index error when creating option (#…
6cc5892 
…12635)

* fix(components): [select] fix error when creating option

closed #12634

* test(components): [select] add test for create and default first option

* fix(components): [select] compatible #11297
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@wzc520pyfm @dannyhebertbell
fix(components): [select] fix hover index error when creating option (e…
14650ac 
…lement-plus#12635)

* fix(components): [select] fix error when creating option

closed element-plus#12634

* test(components): [select] add test for create and default first option

* fix(components): [select] compatible element-plus#11297
@btea btea mentioned this pull request Jan 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@jw-foss jw-foss Awaiting requested review from jw-foss

Assignees

@btea btea

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
3 participants
@btea @tolking @ryuhangyeong