Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select] fix hover index error when creating option #12635

Merged
merged 3 commits into from
Aug 31, 2023
Merged

fix(components): [select] fix hover index error when creating option #12635

merged 3 commits into from
Aug 31, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Apr 27, 2023 •
edited

closed #12634

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023 •
edited

@github-actions
Copy link

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@wzc520pyfm wzc520pyfm changed the title fix(components): [select] fix error when creating option fix(components): [select] fix hover index error when creating option Apr 27, 2023
@github-actions
Copy link

github-actions bot commented Apr 27, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12635
Please comment the example via this playground if needed.

@wzc520pyfm
Copy link
Contributor Author

This is Example: Link
image

Before this PR:
Component automatically checked 'JavaScript' and 'Java' can't be adjusted by arrow keys.
image

@chenxch
Copy link
Member

chenxch commented Apr 27, 2023

@wzc520pyfm Good job, would you mind adding a test case for it.

@wzc520pyfm
Copy link
Contributor Author

@chenxch
I have added the test case, please review again.

@wzc520pyfm wzc520pyfm mentioned this pull request Jul 3, 2023
Merged
3 tasks
@wzc520pyfm wzc520pyfm mentioned this pull request Jul 9, 2023
Closed
@btea
Copy link
Collaborator

btea commented Jul 11, 2023

It seems that this modification will cause the problem fixed by #11297 to reappear.

@wzc520pyfm wzc520pyfm force-pushed the fix-select-create-hover-index branch from ab8d391 to 5e2d24b Compare July 30, 2023 11:10
@sssir
Copy link

sssir commented Aug 10, 2023

This bug seems to remain unresolved.

@btea btea mentioned this pull request Aug 16, 2023
Closed
3 tasks
@wzc520pyfm wzc520pyfm force-pushed the fix-select-create-hover-index branch from 5e2d24b to 66ee3eb Compare August 20, 2023 13:34
@wzc520pyfm
Copy link
Contributor Author

@sssir Now, I think this PR related issue has been fixed, the following is the example link after the fix:

cc @btea @chenxch

btea
btea approved these changes Aug 20, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGYM

@btea btea requested a review from tolking August 20, 2023 14:16
tolking
tolking approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 6cc5892 into element-plus:dev Aug 31, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Sep 14, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@wzc520pyfm @dannyhebertbell
fix(components): [select] fix hover index error when creating option (e…
14650ac 
…lement-plus#12635)

* fix(components): [select] fix error when creating option

closed element-plus#12634

* test(components): [select] add test for create and default first option

* fix(components): [select] compatible element-plus#11297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@chenxch chenxch Awaiting requested review from chenxch

Assignees

@wzc520pyfm wzc520pyfm

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [select] when use allow-create + filterable + default-first-option, hoverIndex error
5 participants
@wzc520pyfm @chenxch @btea @sssir @tolking